Adrian Reina Lobaina
@adrian-reina-391All comments
- @Control222Submitted 5 months ago@adrian-reina-391Posted 5 months ago
Hello, the submitted code is from another project, in the mobile view you don't leave space between the card and the body, also great jon in the wider screens
0 - @PetyaBiszepsSubmitted 6 months agoWhat are you most proud of, and what would you do differently next time?
I can't say I'm proud of something here, but I feel that's a good start to actually START to code. It's a big difference between watching someone coding and coding by yourself so it gives you good practice and makes you try to find solutions for the problems you are facing during creating this project.
I found out some new HTML tags during this project (e.g. table tag), got better understanding of fundamentals of both HTML and CSS and of course @media tag which is required to make this layout responsive, including mobile devices. That's a good start as I said!
What challenges did you encounter, and how did you overcome them?The most important thing I faced during this project is creating a mobile version of this page. I have never looked at @media tag before and its really important skill in my humble opinion. Some overall structure understanding is also a challenge for a newcomer here, but for me it was easier than that.
What specific areas of your project would you like help with?Firstly, I want overall opinion on this page. Does it work as it should? Is there any recommendations in terms of tags, maybe some coding tricks I could use to make my code more clear and the most important, is it good in terms of 'looking like example'. Also it would be amazing to get some recommendations how to work without figma since I'm not premium user. I know it's possible but the only way I could find some numbers is Photoshop. Are there some better ways to do it except figma?
@adrian-reina-391Posted 6 months agoit looks good, but It should have a margin-bottom too, in mobile view it should not have a border radius, check mine if you want
Marked as helpful0 - @amann7974Submitted 7 months ago@adrian-reina-391Posted 7 months ago
you need to put a max-with to the main class, 0.7 opacity to the quotes, font-weight also wrong, the styles of these and other elements are in the readme-style.md file that is downloaded with the project
0 - @mateo1627Submitted 8 months ago@adrian-reina-391Posted 8 months ago
hello, you should add border-radius to the cards, and also reduce font-weight in the titles, the mobile view should break at 768px width
0 - @Anoop-RajoriyaSubmitted 8 months ago
- @Abe-isCharlieSubmitted 8 months agoWhat are you most proud of, and what would you do differently next time?
probably the responsive part
What challenges did you encounter, and how did you overcome them?none
What specific areas of your project would you like help with?no one, ig
@adrian-reina-391Posted 8 months agoit´s good but what ever you did to stylish theOrdered List you should do it for the UL too, in mobile -view the second line dont start below the first
0 - @CodeCraziness92Submitted 8 months agoWhat are you most proud of, and what would you do differently next time?
I'm proud of the styles, the divisions and some organizing techniques. I will do different next time on the styles, it's too big and a bit confusing.
What challenges did you encounter, and how did you overcome them?The challenges i faced up was the CSS (in paddings, widths, margins and aligns), i had to ask to GPT how to do some things and saw how to do some codes at free code camp.
What specific areas of your project would you like help with?CSS padding, widths, heights and margins on lists, images and organizing the texts, so it looks better and less strange.
@adrian-reina-391Posted 8 months agoyou should add margin top and bottom in the desktop view, but the list were perfect i had it similar but i canged ir because I didnt get any way of getting the bullets in one color an the text in other, now i see it so simple, i used spans for bullets and tables to position it, but your way is better, even when i am missing something , how you could make that the numbers in the ordered list, stayed in the top of their spaces , in my it goes to the middle
Marked as helpful1 - @joacomendaSubmitted 8 months agoWhat are you most proud of, and what would you do differently next time?
Im most proud of the use of media queries to make the site more respnsive in mobile
What challenges did you encounter, and how did you overcome them?It was the first time using Media queries, it was hard but I thing it turned out nice
What specific areas of your project would you like help with?How can I improve mobile design to be more responsive
@adrian-reina-391Posted 8 months agoFor Next Time I will use de a tag for the links, not buttons
0 - @HerveWaboSubmitted 8 months agoWhat are you most proud of, and what would you do differently next time?
Proud of the use of semantic HTML elements as much as possible. Next time I'll take more time to arrange my CSS for it to be less repetitive.
@adrian-reina-391Posted 8 months agoGret Sizing, it´s a copy of the original
0 - @pxtricixdevSubmitted 8 months ago@adrian-reina-391Posted 8 months ago
Great way to do it, it was useful for me, i see my faults
1 - @MikhelRhyzSubmitted about 1 year ago
feedback please
@adrian-reina-391Posted about 1 year agoHonestly, it was not so difficult to make, until that point, but adding the eye SVG icon that appears when you hover on the main image, has been hard, I don't even understand why I had it to do it that way. Check mine: https://adrian-reina-391.github.io/myfrontendmentorprojects/challenges/4-nft-preview-card-component-main/index.html
Marked as helpful0