@MatheusVSNSubmitted over 1 year ago
This is one of my first projects on Frontend Mentor. I didn't find hard at all while building the project, but i'm uncertain about positioning elements on the center of the screen.
adityapandey51
@adityapandey51All comments
- @Chandima-RSubmitted over 1 year ago@adityapandey51Posted over 1 year ago
Hello there 👋. Congratulations on job well done! 🎉 🎉 🎉
I would like to make some suggestions concerning your code that I might be of help. HEADINGS ⚠️:
HTML 🏷️:
This solution generates accessibility error report: "All page content should be contained by landmarks". This is due to a non-semantic markup, which causes a lack of landmark for a webpage. So fix this by replacing the <div class="container"> element with the semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file. What is meant by landmark ?: They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers. We make use of sematic elements to provide landmarks to our webpage example includes <main>, <aside>, <footer>, etc., instead of relying on generic elements like <div> or <span>. Every webpage should contain one <main> element and it should include all content directly related to the page's main idea, there should only be one per webpage.
Image ⚠️: And include an alt attribute in your img.
Well done for completing this challenge 👍
I hope have been of help, Please feel free to ask any question
Happy Coding 🎉
0
