Aditya Pratap
@aditya3284All comments
- @abdu-shakurSubmitted about 1 year ago@aditya3284Posted about 1 year ago
Hey @abdu-shakur,
π body can use a
min-height:100dvh
display: flex;
flex-direction: column;
align-items: center;
justify-content: center;
, which will place your rating component in center of the screen.π And you can remove
align-items: center;
,justify-items: center;
from thediv
with general class.I hope this helps you. Cheers
Happy coding π
Marked as helpful0 - @iyanu752Submitted over 1 year ago
images dont appear on my site when ever i host them, please i need help in fixing this, ive tried everything i can from making sure the file directory is correct to making sure all the images are spelled correctly
@aditya3284Posted over 1 year agoHey @iyanu752,
I found your solution in my feed.
You are facing the issue of not able to use images when you host then, i think it is because
π you are using the relative address of the images in the
src
, which is alright, but what happens is that, due to the nature of relative addressing the browser tries to find the images relative to the file, in this caseindex.html
.But as you have not uploaded the images folder to the repo, its not able to find it, falling back to the alt text of the image.
Solution : Simply added the
images
folder to the repo, then you favicon, article image and avatar image will work as intended.π Also your accessibility report is showing that you don't have a
h1
, so try to utilizeh1
before usingh2
.I hope this helps you.
Cheers
Happy coding π
Marked as helpful1 - @LuchoUrtubeySubmitted over 1 year ago@aditya3284Posted over 1 year ago
Hey Lucho, good job
I too submitted my solution for the same challenge, and found your's in my feed.
Your solution looks great however I think that their can be some modifications.
π
body
can use amin-height:100vh
, which will make it take the whole screen's height.π And also instead of using margins to position the card element at the center of the screen, utilize
display:grid;
ordisplay:flex
and then use property likeplace-items
.I hope this helps you.
Cheers
Happy coding π
Marked as helpful0 - @Abhilash437Submitted over 2 years ago
I am a beginner in web development but I have tried my best to comping up with a solution for this challenge, it has a lot of bugs but somehow it still works. Feel free to provide some insights on my solution.
@aditya3284Posted over 2 years agoHey Abhilash, good job
Keep up the good work
Your solution looks great however I think that the hr that you are using needs a bit more size or opacity, as its not visible properly. And try to use other units instead of % on your main container, as % changes based on the parent element, in this case parent element is the body and change in its width changes your components width.
@ccreusat has given a good solution of that.
I hope this helps you in your coding journey
Cheers
Happy coding π
0