@dejuliansrSubmitted about 2 months ago
Alejandro
@adelayglesiafleitasAll comments
- @adelayglesiafleitasPosted about 2 months ago
"Hello @dejuliansr! Excellent work with the code! I just have a small suggestion: it would be great if the query type changed to a light green background when selecting one of the two options. It's a minor detail. Keep it up!"
1 - @matt2282Submitted 3 months agoWhat challenges did you encounter, and how did you overcome them?
Creating the accordion itself was a challenge because I wanted it to only display one item at a time and close the other tab question that was open before it. I had to figure out how to keep track of which question was open and how to change the plus or minus image back to the appropriate state as well.
@adelayglesiafleitasPosted 3 months agoGreat job! I congratulate you on your effort. I would like to suggest that you use the <main> tag for the main content and the <footer> tag for the footer provided by the platform. This not only improves the semantic structure of your document but also enhances accessibility and understanding of the content. Keep it up, you're doing great!
0 - @SajadiaHouseSubmitted about 1 year ago@adelayglesiafleitasPosted 6 months ago
Hi @SajadiaHouse, good job! I would recommend using semantic tags like enclosing everything in a <main> tag and dividing content into <section> tags. You can still use <div>, but within semantic tags. That's my advice. Everything else looks good, congratulations!
0 - @mrcordovaSubmitted 6 months agoWhat are you most proud of, and what would you do differently next time?
I am proud of figuring out how to use radio buttons, css and one line of javascript to get the preset tips stay active, it was surprising involved process.
What challenges did you encounter, and how did you overcome them?Working out the logic on when to enable reset and update the totals.
What specific areas of your project would you like help with?How can I make the layouts and fonts more responsive. Any general feedback is welcomed.
@adelayglesiafleitasPosted 6 months agoHi, great job! I congratulate you on the validation you did for values 0 or lower, I think I will add that to mine if you allow me. Good use of semantic tags in HTML, well-organized code, congratulations!
0 - @SandyAstorgaSubmitted 6 months agoWhat are you most proud of, and what would you do differently next time?
I took the opportunity to customize the component by integrating my profile ❤️
What challenges did you encounter, and how did you overcome them?--
What specific areas of your project would you like help with?--
@adelayglesiafleitasPosted 6 months agoGreat job @SandyAstorga, good use of semantic tags, the code is organized, I liked that you personalized the design, my suggestion would be that the image had the same resolution as the challenge, since the design is lost a bit, but overall very well done, congratulations, regards.
0 - @OG0808Submitted 8 months ago@adelayglesiafleitasPosted 7 months ago
"Hi OG0808! Great job! I would like to suggest that you label the main container as <main>. Congratulations and greetings!"
Marked as helpful0 - @lokesh-webySubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
I finished my project after several failures
What challenges did you encounter, and how did you overcome them?I encountered at positioning the elements
What specific areas of your project would you like help with?Able to find the width and height
@adelayglesiafleitasPosted 7 months agoHello @Lokesh0212004! In advance I apologize for the fact that English is not my native language, look at the challenge, it applies to 2 types of resolutions Mobile: 375px Desktop: 1440px I mean it puts it in the style of the challenge, so your work is oriented towards these 2 resolutions, the first thing I do is the mobile one since there are times when the other one comes out easier since it would be adjusting the long width etc., you can do this do with: @media only screen and (min-width: 1440px) { "code here html" } I hope it is useful to you and in advance excuse my English all the best
0 - @NurAmmarNaufalSubmitted 7 months ago@adelayglesiafleitasPosted 7 months ago
hi @NurAmmarNaufal good job, I would advise you to use html semantics such as main to group the content, and another thing could be that you create the css code in a separate file so that you separate html from css, that always helps with reading easier code otherwise I see it well good job
Marked as helpful0 - @lokesh-webySubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
I finished my project after several failures
What challenges did you encounter, and how did you overcome them?I encountered at positioning the elements
What specific areas of your project would you like help with?Able to find the width and height
@adelayglesiafleitasPosted 7 months agoHello @Lokesh0212004!
I wanted to congratulate you on your good work. I would recommend using semantics in your HTML code, as this helps search engines better understand the content of your page. For example, you can structure your content using elements like <main> and <section>, which improves the readability and accessibility of your site.
Additionally, I would advise you to check your work at a resolution of 375px. It is a good practice to design first for small resolutions and then scale up, as this ensures that your design looks good on different devices.
I hope these tips are helpful to you. We are here to help each other. Best regards!
I hope this translated version meets your expectations. Let me know if you need any further assistance!
0 - @Bishwajeet-07Submitted 7 months ago@adelayglesiafleitasPosted 7 months ago
Hello @Bishwajeet-07, good semantics and the code is well-structured and readable, I congratulate you.
Marked as helpful1 - @MrDullSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
i'm just glad i could do it.
What challenges did you encounter, and how did you overcome them?- the qr image didn't fit into div but somehow i got it right. more or less
- div wasn't centered properly but somehow i got it right. more or less
- text an their padding was all over the place but somehow i got it right. more or less
looots of trial and error.
What specific areas of your project would you like help with?i don't have any specific questions, any feedback is welcome
@adelayglesiafleitasPosted 7 months agoHello @MrDull, good job, to center the module group it and apply margin: 0 auto in CSS. Set the side margins to "auto". Another thing you can do is use an external CSS and load it on your site, which makes it more readable when reading the code and it is very convenient to separate CSS from HTML:
Create a separate CSS file with your CSS code. For example, you can name it styles.css and save it in the same folder as your HTML file.
In the <head> of your HTML file, add a <link> tag with the following attributes:
<link rel="stylesheet" type="text/css" href="styles.css"> Where href is the relative path to the CSS file you created.By following these steps, you can load an external CSS file into your HTML document, separating the CSS from the HTML code for better organization and readability. Keep up the good work! Best regards.
Marked as helpful1 - @hoda257Submitted 7 months agoWhat are you most proud of, and what would you do differently next time?
Finishing this challenge
What challenges did you encounter, and how did you overcome them?Adjusting cards in this layout
What specific areas of your project would you like help with?Nothing for now
@adelayglesiafleitasPosted 7 months agoHello @hoda257, good job, good use of semantics, just a few tweaks on the scale of the cards, but overall very good work, congratulations.
0
