This is my step to the world of Web Development. Please let me know if I can improve anything. I would love to get your suggestions.🥰
Adarsh Pratap
@adarshcodesAll comments
- @AryaDixitSubmitted 10 months ago@adarshcodesPosted 10 months ago
Hi @AryaDixit, first of all, welcome to this amazing community! You did nice work on this solution👏.
Few things I've liked and noticed about your solution:
Design aspect: Your design is very similar to the given design file. Only a couple of things I've noticed that you can change the font colors for the paragraphs.
Responsive aspect: It's responsive and will work on most of the screens. Good work.
Functionality aspect: It's working fine.
Code: While everyone has their own style and approach to code few things make the code clear and clean and you really did amazing work on that.
Accessibility and HTML Issue: You can check the report and you'll notice very small issues causing those issues, you can always fix that and regenerate the report here.
You did amazing work👍. Keep practicing. Happy coding :)
1 - @JFREUNSubmitted about 3 years ago
Hiya!
This is my solution. Any tips or recommendations are welcome!
@adarshcodesPosted about 3 years agoHi @JFREUN, you did nice work on this challenge. Your design is very close to the original one. Keep up the good work👏
0 - @seanyoung247Submitted about 3 years ago
This is my first react project, so I'd be interested to hear all the ways I got react wrong :).
@adarshcodesPosted about 3 years agoHi @seanyoung247, first of all, let me tell you I've done this project and I know it's really hard. Second thing is you not only nailed it but also took it to another level🤯. I myself am the person who tries to add many extra things and animations in my solution but this solution is really very amazing and I really loved it.😍
The subtle animation and the addition of extras without messing with the actual design. Amazing👏👏👏.
I can't give you the review on your react code as I'm a newbie in react. Just fascinated with the solution.
Happy Coding :)
1 - @carlin-mitchellSubmitted about 3 years ago
I know that there is a lot for me still to learn. My next goal will be to re-factor this project as I get more experience with best practices.
My main question is: Can I keep the background image centered when I resize the window in only one direction?
@adarshcodesPosted about 3 years agoHi @carlin-mitchell, first of all, welcome to this amazing community, and you did really nice work on your first challenge👏.
And yes there's a huge room to learn the best practices which you'll learn eventually by practicing. Just a suggestion from my side is to keep working on the project consistently and take a look at others' code but don't carry it away by the approach of others. Every one of us has our own style of coding the things you should learn is the best practice and what you like in others' code. Create your own style of code while keeping the best practices in mind.
For your question: leave the background image to the top only, it'll mess with the design if you centered it.
Congratulations on submitting your first solution🎉🎉🎉. It's a long and beautiful way to go. Keep learning and practicing. Happy Coding :)
P.S: take a look at your accessibility and HTML issues and try to fix them. And yeah, Every mistake is an opportunity to learn something new, so never miss it.👍
Marked as helpful1 - @JrlinkinSubmitted about 3 years ago
Open to feedback, tips, and suggestions! Thank you. :D.
@adarshcodesPosted about 3 years agoHi @Jrlinkin, you did nice work on this solution👏.
Few things I've liked and noticed about your solution:
-
Design aspect: Your design is very similar to the given design file. Only a couple of things I've noticed missing are the icons on the bills and the number of person input fields.
-
Responsive aspect: It's responsive and will work on most of the screens. Good work.
-
Functionality aspect: It's working fine.
-
Code: While everyone has their own style and approach to code few things make the code clear and clean and you really did amazing work on that. I like you added the comment wherever needed and your code looks really clean.
-
Accessibility and HTML Issue: You can check the report and you'll notice very small issues causing those issues.
You did great work👍. Keep practicing. Happy coding :)
Marked as helpful2 -
- @NafsukiSubmitted almost 4 years ago
I coded desktop first, using Sass and grid layout.
It was very challenging for me to keep the image fully covered inside of the div, and change the content's order for the responsive layouts. JS email validation part was very exciting to learn.
Any feedback & suggestion for improvement would be very much appreciated :)!!
@adarshcodesPosted almost 4 years agoHi @Nafsuki, your solution looks really nice.
- Design looks similar to the original one, make the width of the container 100%, it will look more similar.
- Responsiveness is working fine. Keep it up. Happy Coding😀
1 - @uBsakuLSubmitted almost 4 years ago
Hello. This time I did on bigger dimensions (1440x800) and tried to be as accurate as possible. One question, how to change button arrow color? Tried color , and background-color, and fill, still nothing. So I did second button instead. If you have any advices, please feel free to share!
@adarshcodesPosted almost 4 years agoHi @FitItGuy, you did good work on this solution. I think most of the things @SzymonRojek has already covered above so please go with the suggestion. Keep it up. Happy coding😀
3 - @RaayaneGomes97Submitted almost 4 years ago
Fedback are welcome
@adarshcodesPosted almost 4 years agoHi @RayaneGomes97, Your solution looks really nice to me👏
- design is similar to the original one.
- Responsiveness is also working smoothly.
- one small thing I would suggest you, add the attribution to the footer.
- Also try to solve HTML and Accessibility issues. Keep it up. Happy Coding😀
1 - @thewebguyySubmitted almost 4 years ago
Please correct me when necessary. and if you wanna work together, please feel free to comment.
@adarshcodesPosted almost 4 years agoHi @thewebguyy, I think you submitted this solution in the wrong challenge section. Please check it.
1 - @Jose-Angel-ReySubmitted almost 4 years ago
Hello everyone!! I would like to receive your feedback on:
• HTML structure 🏗
• Responsive design 🖥💻📳
• Positioning of elements
and if you have any recommendations on something I need to improve that would be great 👨🏼💻🙏🏼
Thanks guys!!
@adarshcodesPosted almost 4 years agoHi @Jose-Angel-Rey, You did a nice job on this challenge. Great👏.
- I like the beating animation on the image.
- HTML structure is fine and the code looks clean.
- Responsiveness is also working great. Keep it up👍. Happy Coding😀
2 - @biancahppSubmitted almost 4 years ago
Please feel free to leave any feedback.
@adarshcodesPosted almost 4 years agoHi @biancahpp, you did amazing work on this challenge👏.
- Your design is pretty similar to the originally provided design.
- I like the small things you added, like the check icon
- Dark mode is working great.
- And every functionality is working properly.
- Responsiveness is also working nicely.
- Try to solve HTML and Accessibility issues. Keep it up👍. Happy Coding😀
2 - @wenadevSubmitted almost 4 years ago
Feedback will be appreciated
@adarshcodesPosted almost 4 years agoHi @wenadev,
- your solution looks really cool and similar to the original design.
- the dark mode is working properly.
- Responsiveness is working nicely as well. Keep it up. Happy coding😀
2