Skip to content
OverviewSolutions
17
Comments
7
Abdulrhman Kotb
@abdo-kotb

All comments

  • Abdulrhman Kotb•395
    @abdo-kotbPosted about 3 years ago

    Great design overall. ⭐⭐⭐ The design looks really good in every aspect, and I loved the addition of JavaScript. Keep up the great work 🔥🔥🔥

    Marked as helpful
    0
  • Fluffy Kas•7,715
    @FluffyKasSubmitted about 3 years ago

    Hey guys! I had a blast building this, even if it was a bit challenging at times! It also gave me a good opportunity to experiment with some new tools and I'm kinda happy with how it turned out. I've changed a few small things (on purpose :P).

    It would be awesome to get some feedback, especially regarding the HTML. I try to pay attention to semantic markup so I'd love to hear some feedbacks on this (or on anything else really).

    edit: When I check on my phone, for some reason it's all messed up, like only half of my css was working. I didn't have this issue with the browser's inspect mode. Can anyone explain me why this may happen?

    Fylo Dark Landing Page using Sass, Parcel, deployed with Netlify

    2
    Abdulrhman Kotb•395
    @abdo-kotbPosted about 3 years ago

    I checked the design on my old phone, and it looks great, so apparently, it has to do with the version or the type of your browser.

    Other than that, your solution looks almost perfect on both desktop and mobile versions, and it helped me figure out an issue with the footer in my solution.

    I only noticed a very minor issue with the productivity-link-holder border on small mobile devices that the border is not exactly the width of the text. You can try using box-shadow, it will make your solution shorter and more efficient.

    Keep up the great work 🔥🔥🔥

    Marked as helpful
    0
  • Radek•115
    @vlkradekSubmitted over 3 years ago

    I failed section "Supercharge your workflow", because the first item is not aligned with others, because the first item has one line more. I will be happy for any feedback :))

    HTML, SCSS, grid, flexbox

    2
    Abdulrhman Kotb•395
    @abdo-kotbPosted over 3 years ago

    Your design looks really good ⭐⭐⭐

    Regarding your question about the Supercharge your workflow section, try to adjust the align-items value of your div class= "items".

    You can find a scrolling issue when using the DevTools, which usually indicates that content is too big to fit into its specified area.

    You can fix that by ensuring that all images can't exceed the sizes of their parents and by using the overflow property.

    Keep up the great work 🔥🔥🔥

    1
  • Abdulrhman Kotb•395
    @abdo-kotbPosted over 3 years ago

    Your design is near perfect. It helped me a lot with the desktop background issue.

    I have a few nitpicks that can help make your design more similar to the original:

    • You can decrease the height of the right-side-color and add margins on top and bottom of it so that there will be a space between it and the parent progress bar.

    • You can also add a background-position to the mobile background to make it look more similar to the original. It only needs one value. 🤫 😆

    Great work ⭐⭐⭐ and happy coding 🔥🔥

    Marked as helpful
    1
  • Abdulrhman Kotb•395
    @abdo-kotbPosted over 3 years ago

    Great design overall ⭐⭐⭐ Just two simple notes:

    You can change the body background-color to something more similar to the original design. You can find the desired color in the style guide file.

    You also forgot to add shadows to the testimonials boxes.

    Keep up the great work 🔥🔥

    0
  • Abdulrhman Kotb•395
    @abdo-kotbPosted over 3 years ago

    Great design overall and works well on all screens. ⭐⭐⭐

    Only a small issue with the right-side paragraph on 1024px to 1070px screens is that some overflowing letters get hidden. I actually had a similar problem. You can try to fix that by decreasing the width of the chat app image on these screens or by providing the image with a vw unit on mid-large screens.

    Keep up the great work 🔥🔥

    Marked as helpful
    0
  • Abdulrhman Kotb•395
    @abdo-kotbPosted over 3 years ago

    Great design overall. ⭐⭐⭐

    You can just try to decrease the h1 font size a bit on 1080px to 1370px screens by using rem or vw instead of em or by applying more media queries. Also a similar issue but the other way around with the right-side paragraph on 750px to 1080px screens.

    Keep up the great work 🔥

    0