Any criticism is welcome! I'd like to know specifically if my HTML markup was correct and if there was anyway I could make it more accessible to screen readers (if there's any thing I could add. I'd also like to know if the way I styled my css would have any conflicts if this was placed in a larger project.
Latest comments
- @AmyH-gooseWhat specific areas of your project would you like help with?@abdelrahman4habib
good job
- @bhp005@abdelrahman4habib
you did a good job :)
about last list, you miss long lines you can do like
border-bottom: 1px solid #ccc} that to make line in every list item, but you will no need last line so you can take this too.. .styled-list li:lastchild {border-bottom: none} also You should put some spaces between lines. letter-spacing: ; good luck and i hope this helped you
Marked as helpful - @leroidu420@abdelrahman4habib
good job
- @viitorags@abdelrahman4habib
good job
- @AmyH-gooseWhat specific areas of your project would you like help with?
Any feedback is welcome!
@abdelrahman4habibgj
- P@PetterTSaatvedtWhat are you most proud of, and what would you do differently next time?
This project gave me great insight into how one might go about adapting a design from a single column layout to a multi column layout and vice versa leveraging media queries, as well as how to substitute the image source when needed. Overall I'm pretty happy about how the solution turned out, but next time I will consider using some css preprocessors to gain experience with those :)
What challenges did you encounter, and how did you overcome them?I think the only real challenge I encountered was how to handle the image change when going from one layout to another. After learning about the picture element through some research it emerged as the perfect solution for this instance.
@abdelrahman4habibyou did a good work You must comply with the required colors ,your(h1)