Skip to content
OverviewSolutions
0
Comments
5
AK_07
@aarsh07

All comments

  • AK_07•60
    @aarsh07Posted about 2 years ago

    Hello Rachel , How are you ?

    Your solution is amazing but I will suggest that instead of using as a background img you should create a flex container then inside it you can create two div one for content and second for img and then you should use object-fit : cover property to properly cover img .

    In your solution img is not showing properly that is the only thing which is not looking good , everything else is looking good .

    I hope this may help you a little bit .

    Marked as helpful
    0
  • Cintia•100
    @ciisiqSubmitted about 2 years ago

    What did you find difficult while building the project? For me was to explain to my partner that we worked together on what to use and why, but it also was good practice for me. The most challenge to us was the mobile responsive because we don't start from this, that should be.

    Which areas of your code are you unsure of? Responsive

    Do you have any questions about best practices? Maybe about mobile sizes, how to make this easier to learn?

    Product preview card component witth just CSS and HTML

    3
    AK_07•60
    @aarsh07Posted about 2 years ago

    Hello Cintia , how are you ?

    Your design is pretty good but you should give a breakpoint at 750px for mobile screen because it is overflowing in mobile design so check that

    Marked as helpful
    0
  • AK_07•60
    @aarsh07Posted about 2 years ago

    This looks good but you should change the space between price in mobile design

    Marked as helpful
    0
  • AK_07•60
    @aarsh07Posted about 2 years ago

    Your submission is almost perfect , i just want to suggest that you should move that card to the center of the body because it's not perfectly in middle for now so that is just not looking good, everything else is pretty well .

    1
  • Mihael•260
    @mihaelpavlakovicSubmitted about 2 years ago

    Hii everyone, this is the first challenge that I have tried to recreate on my own. I'm so happy about how it turned out, but I think I could further improve in writing cleaner code.

    It would be helpful for my future growth if you could point me in the right direction. For example, I'm interested in potentially better solutions for this challenge. In which area do I need to improve, and what do you recommend that I should implement? What are some best practices that I haven't got right?

    Thanks for your attention and all the future feedback.

    Responsive product preview card component that was built with flexbox.

    1
    AK_07•60
    @aarsh07Posted about 2 years ago

    As your first challenge it is pretty good , you can add box-shadow on hover effect and further you can add a transition on hover effect on button too . Keep it up your code was good

    1