...made with a lot of love 🤘🏻🙂
A1ex
@a1excpunkAll comments
- @CheosphereSubmitted 10 months ago@a1excpunkPosted 9 months ago
Great job, I have one little piece of advice, and because you are keen on details, I think you'll like it :) About list item disc styling, you can change colour, size etc. by using ::marker pseudo-element on the li tag.
Marked as helpful10 - @aliseidu8855Submitted about 1 year ago
Need review of this project to improve
@a1excpunkPosted about 1 year agoHello there, congrats on completing this challenge,
- one thing I would suggest is to use grid
{display: grid;}
instead of flex. flex can be very useful and easy to use but in some cases, it makes more "trouble" than good. - the reason I'm suggesting a grid is that, on screen size change cards squish and space between cards becomes uneven. with the grid it gonna be smoother and easier. you'll need only one parent container and 5 cards that's it, no additional containers and headache on how to position them correctly.
- A Complete Guide to CSS Grid This is a very good source for understanding grid, for any level.
Keep going, keep learning and of course keep coding.
0 - one thing I would suggest is to use grid
- @Dagime-TeshomeSubmitted about 1 year ago
Suggestions on how to make the page more responsive would be helpful.
@a1excpunkPosted about 1 year agoGood start, keep on practising. About suggestions:
- about media queries, less is better and in this case, you don't need 2, write "main" and go from there to desktop or to mobile screen size (depends on which one you'll make the main one). browsers are doing a good job of making everything responsive so there is less styling code needed from developers regarding that aspect.
- the fixed width is messing a lot for responsiveness, try relative units like %, rem, em and so on. Also, max-width and min-width can be your friends.
- lastly, if you have media queries (especially several), don't copy the whole block of code, set initial values and when media queries are needed (on specific width for example) they will override only the part that is different for that width and needs to be changed.
Marked as helpful1 - @lirapanciSubmitted over 1 year ago
This is another challenge that I've completed. This time I used WordPress and Advanced Custom Fields (ACF) to develop the website. As well as on other projects, I've been using Tailwind CSS and Vanilla Javascript.
Due to restrictions about where a project can be uploaded, I had to generate an HTML version of the WP theme I developed and uploaded it on a separate repository.
I'd really appreciate your feedback.
@a1excpunkPosted over 1 year agoGood job, but some style issues were noticeable,
- on the main page cards text is shifted to the side, if the width of the screen is more than 1440 (I was not checking intentionally, it happened that I saw your solution on a bigger screen.)
- same issue as above but on the stories page, but here not the text is shifted but the whole cards grid behaves a bit off.
I guess it was a 1440 limitation in the guidelines, but if you put a limitation, put it globally, so some parts "don't know" screen is wider. (in this case, the grid container knew so it went on but the cards didn't adjust)
and 3. on the pricing page, the toggle transform between monthly and yearly is a bit off.
keep going and once again, good job.
Marked as helpful0 - @adershgrSubmitted over 2 years ago@a1excpunkPosted over 2 years ago
Good job on the desktop version but the mobile version looks a bit off.
- image borders.
- width.
- transition from desktop to mobile.
Good luck and keep coding 🤘🏻
0 - @waikooSubmitted over 2 years ago
I found it challenging to find a logical place for the attribution. I enjoy taking a zoomed in look around the proportions and scales of things, but placing them on the canvas can get tricky. I may have found a working solution of simply using flexbox and centering things that way, with the html getting a 100% height, this works really well for single item presentations.
When there's not too big of a visual difference in the mobile vs desktop view, it can get tricky sometimes to tell the difference but I enjoyed it very much.
Any feedback is appreciated!
@a1excpunkPosted over 2 years agoGood job, but one thing that stood out is height when the screen is shorter than the component, the component doesn't scroll, top part "disappears".
tip_1: Use, in your case, body{min-height:100%;} instead of just height. tip_2: Add some body padding to separate the card from the edges a little bit.
Good Luck and Keep Going 🤘🏻
Marked as helpful1 - @hcxwebSubmitted over 2 years ago
Hello everyone, this is my 10th challenge, which feels like another level due to its larger size and an addition of tablet view. I spent quite some time trying to make it as close as possible on all screen sizes, and I'm happy with the result. Like always I appreciate any suggestions. Thanks!
- @aladin002dzSubmitted over 2 years ago@a1excpunkPosted over 2 years ago
good static component, but responsiveness is ... well not even a trend but a necessity. also, there are some small details, like
- anchor tag instead of a button tag (for some it might be a preference thing, but when it's a button it should be in the button tag)
- button background colour
1 - @gdcristeaSubmitted over 2 years ago
- @chioreanradudandanSubmitted over 2 years ago
I know for sure this can be improved but I'll take it as a first attempt 😅
@a1excpunkPosted over 2 years agoGood job,
although small details can be improved, "bg-pattern-1.svg" this one creates a horizontal scroll under 1440 and kinda makes the whole thing a bit off. :)1 - @DrMESAZIMSubmitted over 2 years ago
All feedback is welcome as well as comments on my YouTube video
YouTube video link: https://www.youtube.com/watch?v=4kwmzLxRoKI
@a1excpunkPosted over 2 years ago- some parts are missing, like - the word "advice", hashtag, quotes, divider lines.
- button doesn't call the method to fetch API, so there is only one call, on page load and that's it.
Marked as helpful1 - @MubeenAhmadShaikhSubmitted over 2 years ago
Hello Community,
Tried Pixel perfect in this challenge any feedbacks are appreciated.
Thanks
@a1excpunkPosted over 2 years agoPixel perfect is kinda "not a good idea" with responsiveness because your work won't be seen on the same dimension devices so if the user misses that "sweet spot" everything scrambles. Plus, you tried pixel perfect with "responsive" units like % and rem, if you want to make pixel perfect work it's a better idea to make it static for both, desktop and mobile versions.
Marked as helpful1