Skip to content
OverviewSolutions
5
Comments
4
Zehn77
@Zehn77

All comments

  • Zehn77•60
    @Zehn77Posted 6 months ago

    Hi,

    1. Try to avoid using, complex css elements like, >, ~, ....
    2. Try to use rem instead of em because when changing the main element font-size it effects all content and it will be easy to maintain project when some design changes occurred
    3. content__container give only max-width, that is enough
    4. I think, I don't need to use id selectors, using class selectors is good practice
    0
  • Zehn77•60
    @Zehn77Posted 6 months ago

    It would be better, to use body { min-heigth: 100vh }, because in small heights your design is cut down!

    Marked as helpful
    1
  • Zehn77•60
    @Zehn77Posted 6 months ago

    It would be better to use media queries, responsible both mobile and desktop devices

    0
  • RedaKaafarani1•40
    @RedaKaafarani1Submitted 6 months ago
    What are you most proud of, and what would you do differently next time?

    I am happy that I could achieve the ending result. Maybe not in the most optimal way, but glad that it works.

    What challenges did you encounter, and how did you overcome them?

    There are a few challenges:

    • How to structure the HTML file (divs, spans, etc.)
    • How to achieve the requested style in CSS, dealing with positioning, margins and padding
    What specific areas of your project would you like help with?

    I mostly would like to achieve better way of thinking when writing CSS. How can I write code that I would know is somehow optimal, not perfect, because this is actually pretty hard, but sub-optimal would be fine!

    Landing page using Flexbox

    1
    Zehn77•60
    @Zehn77Posted 6 months ago

    It would be better to use css variables!

    0