All comments

Solo Incrementing•40

@Solo-IncrementingSubmitted about 1 year ago

Are there any parts to my code which are not best practice that I should avoid doing?
Is there anything I should do to improve my workflow?

Simple QR code page

YounusUID•0

@YounusUIDPosted about 1 year ago

I suggest following improvement in your CSS code. I just write CSS that should be remove or edit.

.card {   
    width: 300px // set width 300px, after adding 15px left/right padding, the actual size will 
                                300 + 15 + 15 = 330  
    height: 500px; // remove this line
    border: none;  // remove this line
    padding: 15px; add this line for add padding to entire box
}
.qr-code {
    width: 100%; // set width to 100%
    margin: 16px auto 0 auto; // remove this line
}
.title {
    width: 250px; // remove this line
    margin: 0 0 20px 0; // add margin bottom
    text-align: center;  // remove alignment from here and add to the parent div
}
.description {
    width: 250px;  // remove this line
    height: 100px;  // remove this line
    margin: 0; // set margin 0
    text-align: center;   // remove alignment from here and add to the parent div
}

Wrap title and description into a div and add padding to set spacing around the div. i.e.

.xyz {
    text-align: center;
    padding: 20px;
}