This was loads of fun specially making this fullstack, learnt alot on the backend side, special thanks you @weewomp1 as this was a joint effort in getting this out. hope you guys enjoy it
Nathan
@YofouAll comments
- @YofouSubmitted about 2 years ago@YofouPosted about 2 years ago
Due to restrictions of the trusted provider I had to settle for vercel which is alot slower provider than my main provider, if you're having connections issues / the app is slow to response I recommend. https://productfeedbackapp.up.railway.app/ which is the same app, just better host
0 - @MasterKrabSubmitted over 3 years ago
I am just a beginner and would appreciate any feedback.
Do I have good practices? What errors do I have? How could I improve my code?
Thanks <3
@YofouPosted over 3 years agoAyyye, nice to see another svelter around :) I ended up doing this challenge in svelte too
some real nice stuff here, for example loved the spin transition you did on the theme switcher. design looks pretty close, being nip picky on the desktop design the remove todo button should only appears on hover
somethings you could of done better is the dragging, I used SortableJS in my project but you could also use DraggableJS this would of saved you some time however in the sport of doing stuff yourself for the fun of it, your implementation is slighlty off putting for one you're blocking interactivity with the done switch and the remove button by making the whole div a draggable component, I would suggest making only the middle part the drag handle as that allows users to still easily move the todo-item but still let them easily click the remove and done switch. another reason why your own dragging logic feels wrong is because once you put your cursor off the todo-container it stops the drag, if you're going to do that I would suggest anchoring the drag-item on the x-axis (so only move the item up and down).
apart from the dragging logic being little wacky, I would also make sure you can't submit an empty todo (although this might be preference) also would make sure you set
border: none;
on the input:focus, so you don't get that out of place dotted line.apart from all that, you did an awesome job! good stuff looking foward to maybe seeing you doing more challenges around here in svelte :)
2