toledolucass• 10
@toledolucass
Submitted
Fin Liaw
@Yakobus-Mardi
All comments
- Fin Liaw• 250
@Yakobus-Mardi
Posted
I recommend using more semantic HTML tags instead of divs. But overall, you are doing a great job.
0 - DivasJaglan• 170
@DivasJaglan
Submitted
What are you most proud of, and what would you do differently next time?
Making this awesome project
What challenges did you encounter, and how did you overcome them?
No challenges at all
What specific areas of your project would you like help with?
Not in this
Fin Liaw• 250@Yakobus-Mardi
Posted
Well done! Your solution is cool and you should continue doing what you're doing. Keep it up.
Marked as helpful
1 - Diego López• 40
@dialoma
Submitted
What specific areas of your project would you like help with?
I don't understand why when I use border radius on my images , it works fine on the top left and right corners, but on the bottom left and right corners it doesnt apply the same way.
Fin Liaw• 250@Yakobus-Mardi
Posted
Good solution. I like the style of the image border-radius.
0 - samdahboss• 70
@samdahboss
Submitted
Fin Liaw• 250@Yakobus-Mardi
Posted
I think for the acknowledgment (Coded by), you have to put it outside the card, so the card of the QR code can be more compact. The title should be bolder and the font size a little bit too small. But overall, it's a good solution. Keep going.
1 - Sarbeh• 100
@herbras
Submitted
I started back my learning journey as web dev
Fin Liaw• 250@Yakobus-Mardi
Posted
Hello, friend
These are what I think you can improve your code on the next project:
➡️ I think it's a good practice if you use more semantic HTML tags instead of div tags. ➡️ Write the code consistently. Ex: for the colors name. ➡️ Using CSS Variable is a good practice too. Especially for the cleaner code.
Above all that, well done on the project. Keep it up. 🙂
1
