Nguyen Duc Tan• 240
@tannguyenk3
Submitted
Yash Bhatt
@Y-ashbhatt
All comments
- Yash Bhatt• 280
@Y-ashbhatt
Posted
Great Solution!
0 - Peter Jacobs• 190
@thisispeterj
Submitted
What are you most proud of, and what would you do differently next time?
The setup of the desktop layout using grid, and the positioning of the svg quote using a pseudo element along with absolute positioning.
What challenges did you encounter, and how did you overcome them?
The main challenges I encountered were in most effectively grouping and naming elements with css classes. I wanted to keep my code as dry, readable, and as reusable as possible. I also found it a challenge to exactly match the box-shadows of the cards, and tried to use the figma design, but ultimately just ended up eyeballing it.
What specific areas of your project would you like help with?
I would really appreciate any guidance on the HTML organization and CSS classes I used for the cards. Specifically:
- What is the most efficient and semantic way to name the cards with different colors
- What is the most efficient and semantic way to name the cards for the grid template needed to position them in the desktop view
- What is the best strategy for taking a box-shadow in a design, and converting that to CSS so that color, spread, blur and x/y positioning are accurate.
Yash Bhatt• 280@Y-ashbhatt
Posted
Nice solution!
0 @anaiswritingcode
Submitted
What are you most proud of, and what would you do differently next time?
In this project I implemented:
- BEM notation
- Custom CSS properties
- Media queries
- Mobile-first approach
- Semantic HTML
- Responsive design
- Grid areas
If I had to change something, I'd like to analyze the given design beforehand to figure out the least extensive route instead of jumping right into the CSS, this way I may be able to write less code than it's really needed.
What challenges did you encounter, and how did you overcome them?
It was my first time using grid areas, but they were very straightforward so everything turned out fine!
What specific areas of your project would you like help with?
I'd be interested in seeing different approaches to this challenge that contain less CSS.
Yash Bhatt• 280@Y-ashbhatt
Posted
Nice Solution. I used flexbox and was thinking how would I do it using grid and this cleared quite a few things.
1- Muhammad Kevin• 80
@muhammadkevinpf
Submitted
Yash Bhatt• 280@Y-ashbhatt
Posted
The solution looks great.
But it seems like you forgot about the active states. This can be done easily using the
:hoverproperty.If you want to learn about
:hoverthis article on MDN is pretty good.If have any questions about it feel free to ask.
Happy Coding.
0 - Pooja Choudhary• 20
@Poojachoudhary21
Submitted
Yash Bhatt• 280@Y-ashbhatt
Posted
Hello.
Your solution looks Great!
I have just a tip:
You've set
width: 22%for the card and this is making it shrink as you reduce the window width. Instead, you can set a max-width to it.And about height, you don't need to set height to the card, because it adapts automatically as you add content to it. Rather you can add padding.
Hope it helps.
Happy Coding!!
0 - AmandeepGuggi• 100
@AmandeepGuggi
Submitted
What are you most proud of, and what would you do differently next time?
I'm really proud of how fast I got this done. And I did this without any external help
What challenges did you encounter, and how did you overcome them?
It made me revise grid properties
What specific areas of your project would you like help with?
should I use grid or not this confuses me sometimes
Yash Bhatt• 280@Y-ashbhatt
Posted
Hello!!
Congratulations on completing this challenge.
There might be some confusion as I checked your code and your have not used Grid but Flexbox.
As for grid it's mainly used to make 2D layouts whereas flexbox is mostly used to make 1D.
A nice guide for Grid is Guide to CSS Grid .
For Flexbox its Guide to Flexbox.
Hope you find it helpful.
Marked as helpful
0 - Rafig• 70
@refikmemmedov
Submitted
What are you most proud of, and what would you do differently next time?
I didn't do much this time. I am still aiming to improve myself and trying to consolidate HTML and CSS.
What challenges did you encounter, and how did you overcome them?
I found it difficult to translate it to the mobile side. I have difficulty making responsive design
What specific areas of your project would you like help with?
I'm currently asking for help from someone on the responsive design.
Yash Bhatt• 280@Y-ashbhatt
Posted
Nice Solution!
As for responsiveness, websites are inherently responsive and most of the time it's our CSS that breaks them lol.
As for your code the problem is the width in
main class.Avoid setting fixed width values for elements like this. You've set width: 100vw. 100VW would represent 100% of the viewport's width, or the full width of the screen. % reflects a percentage of the parent element's size, regardless of the viewport's size. Instead, you can set a max-width to it or give it no width.
Go through the LEARNING PATHS. I'm learning responsive design through them, they're pretty good.
Hope it helps you.
Marked as helpful
2 - Rajendra Negi• 30
@Rajendra-Negi
Submitted
Yash Bhatt• 280@Y-ashbhatt
Posted
Hello!
Congratulations on completing this challenge.
I can't open your code, your Github link seems to be not working. You should check it.
And I also have a suggestion for you:
- In your Media Query you have set
max-width :328px. But 328px is too small even in style guide it has width of 375 px.
For some common breakpoints for widths of devices:
- 320px — 480px: Mobile devices
- 481px — 768px: iPads, Tablets
- 769px — 1024px: Small screens, laptops
- 1025px — 1200px: Desktops, large screens
- 1201px and more — Extra large screens, TV
Hope it helps.
0 - In your Media Query you have set
- P
@Josmiga
Submitted
What are you most proud of, and what would you do differently next time?
Im very proud about make my first responsive page, a mean, you can see thiis page perfectly in your mobile device and your desktop browser.
What challenges did you encounter, and how did you overcome them?
In the last projects I always set a default width on my main , this time I use a scalable width and that makes me do a little research about responsive pages because my page was going crazy with the layouts.
What specific areas of your project would you like help with?
I want all the advices posibles about responsive images.
Yash Bhatt• 280@Y-ashbhatt
Posted
Hello!
Your solution loooks pretty good.
But I noticed there was tiny mistake in rounding the corners in the Image. In the desktop design it still follows the mobile design format.
For giving corners different border radius try this article Border Radius. This explains how to separately round each corner in a simple way.
I hope you find it helpful.
Marked as helpful
0 - ofentse-freecode• 180
@ofentse-freecode
Submitted
Yash Bhatt• 280@Y-ashbhatt
Posted
Good Solution!
I have a few suggestion for this:
- In the mobile design you can give padding to the
info divinstead ofcard divit would not give padding to image only text. - You can give
color: whiteproperty to your button to make the text white. - For giving corners different border radius try this article Border Radius. This explains how to separately round each corner , its pretty easy.
Good Luck!
Marked as helpful
1 - In the mobile design you can give padding to the
- Elias Mahfuzul• 90
@code-elias
Submitted
Yash Bhatt• 280@Y-ashbhatt
Posted
Great Solution!!
0 - Gia Miminoshvili• 170
@giamimino
Submitted
Yash Bhatt• 280@Y-ashbhatt
Posted
Hello!
Great Solution!
But I have a suggestion you can use:
body{ height:100vh }A value of 100vh is equal to 100% of the viewport height. This will make the body take full viewport height and help centre the child in page properly.
Marked as helpful
0
