Skip to content
OverviewSolutions
8
Comments
3
Wedrussowo
@Wedrussowo

All comments

  • Wedrussowo•80
    @WedrussowoSubmitted over 1 year ago

    Hello.
    In this project I started to use grid and tried to understand it better. For now it's harder than flexbox - definitely :D but it's just the beginning.

    The project was quite pleasant, yet newbie-demanding. I Feel like there is too much code in CSS, it can probably be reduced somehow.

    Anyway, I enjoyed coding this project. Any feedback about what can I improve, especially with the grid appreciated! ;)

    Thank You!

    order summary component first steps with grid

    1
    Wedrussowo•80
    @WedrussowoPosted over 1 year ago

    Some minor details are different than in the challenge, I have old monitor for now and was hard to catch those. Will try to make it better next time.

    Cheers ;)

    0
  • CSweetman•10
    @CSweetmanSubmitted almost 2 years ago

    Are there any glaring issues with the solution?

    In terms of responsiveness are there better practices I can be implementing?

    Qr Code component using flexbox

    1
    Wedrussowo•80
    @WedrussowoPosted almost 2 years ago

    Hello,

    You got error about the image.

    • It means that an <img> tag in HTML should have also alt attribute which is used to specify an alternative text description of the image.
    • This is important for accessibility as users with visual impairments or using screen readers need text description to understand the content of the image. Here's an example: <img src="image.jpg" alt="Image description">

    Good Luck.

    0
  • Wedrussowo•80
    @WedrussowoPosted almost 2 years ago

    Thanks, a lot for this comment! It really helps to understand more thinking process of modern frontend developers. I have couple questions related to your comment.

    if I understood it right,

    • I should use more semantic HTML and just style it with CSS? For example, instead of using <div>.frame just use <main> and style it?
    • better don't border radius the image itself, instead wrap it with the div and use the border radius on the div?

    That idea when making components and add to it an <h1> tag for sr just for training sounds very good. I'll definetly try!

    Thank You for all the time you put into helping me.

    0