@VovaKuzmenko
@markharrison777
Submitted
What are you most proud of, and what would you do differently next time?
On this project, I used BEM for my CSS and HTML
What challenges did you encounter, and how did you overcome them?
Not too many challenges if any at all, pretty straight foward project.
What specific areas of your project would you like help with?
None for now
@VovaKuzmenko
Posted
Thanks for the feedback. B.E.M. I think it would be better to make the transition "container__card-info" => card-info and remove "container__" from the name. Leave "card-info". And the shadow, it is different in the main picture and with hover...
Marked as helpful
@surrealgee
Submitted
What are you most proud of, and what would you do differently next time?
I decided to use BEM for the first time. I think it's a really useful methodology.
What challenges did you encounter, and how did you overcome them?
I ran into a merge conflict while pushing the project to the remote. I did a rebase and then did a forced pushed since I'm the only one working on it.
What specific areas of your project would you like help with?
Any feedback it's going to be appreciated.
@VovaKuzmenko
Posted
BEM is great. Pay attention to the hover: from should be on "card" and "h1" At small sizes the card sticks to the edges of the screen
@jiricmiel
Submitted
What are you most proud of, and what would you do differently next time?
I've pushed myself to learn version control system which I was avoiding for some reason. Next time I could try not using partials for element that easy but it was good training and it is probably worth practising every time.
What challenges did you encounter, and how did you overcome them?
Most challenging at this project was learning GitHub and make it running. I can't say that I overcame it but I certainly can use it now and I'm going to stick with it and hone it.
What specific areas of your project would you like help with?
As a beginner I struggle with many things. At this project I could use some help with checking my BEM usage, code structuring and partials.
@VovaKuzmenko
Posted
The task was 1440 - 320 is OK. You can do better by not setting the maximum for the monitor. I think the code is good. I used SASS - great. The code is easy to read.
