D3 is very versatile but a bit hard to learn. I wanted to complete this challenge to practice a bit. I could have made the hover feature better but went for the title
solution. I think I can make it work while fetching dynamic data.
Vincenzo Marcovecchio
@VincenzoMarcovecchioAll comments
- @VincenzoMarcovecchioSubmitted over 2 years ago@VincenzoMarcovecchioPosted over 2 years ago
Thank you so much for your answer
Yeah I should fix the errors and be more concern to the designs
One question, is it asking for your position the
iframe
? I totally forgot to remove itFEM doesn't allow urls other than the ones they have whitelisted, this can be some kind of bypass? not really, but I just wanted to throw my solution in there. And also because I had d3 installed there
0 - @ddaniel27Submitted over 3 years ago
Hey everyone, this is my solution using just CSS3 and HTML5. I didn't want to use Javascript for navbar behavior because I did want to try use just CSS3. My question is, Is there another way to do this with just CSS3 or with Javascript I can do it better in behavior sense?
@VincenzoMarcovecchioPosted over 3 years agoHey there, I like your navbar solution using CSS only, I think it can be used in production or at least it's very close but there are many bugs I noticed throughout the website that make it to be reviewed. Mostly you need to review heights and paddings your are giving to sections (if you are concerned to design). Font style is loaded correctly but is not the same as the design also. You should have a look at some CSS transitions animations here https://freefrontend.com/css-menu/ and here https://fireship.io/lessons/css-responsive-icon-navbar/ to keep practicing 👍
0 - @KiriRatanakSubmitted about 4 years ago@VincenzoMarcovecchioPosted about 4 years ago
Sir, I think this is a good job, well done! 👏🎉 What you can do to make it perfect is fixing those accessibility errors, giving the input the
aria-label
attribute is a good start... I forget these things as well...1 - @josnoSubmitted about 4 years ago@VincenzoMarcovecchioPosted about 4 years ago
Hey I like your solution!
I recently discovered another way to write this markup, It might be the best way to go next time
<details> <summary>How many team members can I invite?</summary> <p> bla bla bla </p> </details>
cheers
0 - @juryousSubmitted about 4 years ago
Feedback appreciated :)
@VincenzoMarcovecchioPosted about 4 years agoYou're not far from design, maybe just a better understanding of sizes and dimensions, that footer got you a little bit higher (we have to make the designer happy) this slider comparison up here helps to see our mistakes. It just takes time though, so keep practicing! Great job 👍
1 - @SenatriusSubmitted over 4 years ago
This definitely felt a fair bit tougher than the previous ones I did. On top of that, I took a break in the middle of this project and the code got out of hand really fast when I came back. Any comments/advice/tips on general code quality (and inevitable redundancy I'm sure) are always appreciated :)
@VincenzoMarcovecchioPosted over 4 years agoGood job man!
From what I can notice here maybe try to fix that
<nav></nav>
element, give it some align-self so that when you hover on the link it's not jumping too muchand try to make the telephone number and the email address on the footer links you can click
Keep practicing 👍 :)
2 - @VincenzoMarcovecchioSubmitted over 4 years ago
I have worked on this project with the help of the Youtuber Florin Pop, i have a general idea of what working with api's is, async functions, and embedding in es6.
One question: When you want to display the borders countries(using .borders property) the api gives you back some three letter abbreviation of the full name, how can i turn that into the full name, any help?
Thank you
@VincenzoMarcovecchioPosted over 4 years agocountries = is my res.json() how can i filter from that for each of those alpha 3 code thank you i'm on the tutorials anyway :)...
0 - @VincenzoMarcovecchioSubmitted over 4 years ago
I have worked on this project with the help of the Youtuber Florin Pop, i have a general idea of what working with api's is, async functions, and embedding in es6.
One question: When you want to display the borders countries(using .borders property) the api gives you back some three letter abbreviation of the full name, how can i turn that into the full name, any help?
Thank you
@VincenzoMarcovecchioPosted over 4 years agoI'm trying to create a function i know i'm really bad at it :)
const borders = country.borders; const fullName = for(let border of borders){ let name = border.name //i know this is wrong return name });
0 - @VincenzoMarcovecchioSubmitted almost 5 years ago
I completed another challenge but i'm not 100% happy with this one :), quick one for you, how have you managed to have bigger svg sizes on the footer and applying the hover effect when pointing on the anchor tag (was trying something like a:hover > svg, not working),yeah the footer is a weird one, overall it was a good practice. If you have any recommendation on how i can improve this code send it on, i appreciate have a nice week end !
@VincenzoMarcovecchioPosted almost 5 years agoOk transform: scale(), i will try it out, the part i'm not 100% happy with, it was just that concerning with the design it was not 100% identical, which is something definitely possible, i actually went back to it and made a couple of adjustment (to track my mind as well i duplicated those svg with a orange replica, used "aside" tags for more semantic html, and actually to fix the "a" accessibility errors i have put in there aria-label="" and title="") perhaps i could have cleaned that glider code a little bit more to make the whole thing a little less heavy. We are working on it :).
Thank you for your time!
1 - @lailton-bSubmitted almost 5 years ago
If you have any tips, I would like to hear!
@VincenzoMarcovecchioPosted almost 5 years agoHey don't forget the input must have a label :)
2 - @VincenzoMarcovecchioSubmitted almost 5 years ago
People, how are you keeping,
I'm submitting this solution knowing that i screwed up on so many levels, i will put it like that, if one of you guys want to have a look at my code and have a better implementation please feel free Thank you so much
@VincenzoMarcovecchioPosted almost 5 years agoThanks you for your help Matt!
I appreciate really, these are some good information you are giving me. Mostly it's the Java Script part that is a bit overwhelming over here, but i will go back to this project many times more probably :) and i will try to fix it in the best way possible, i will!
I should avoid html mistakes now...
Thank you again!
0 - @VincenzoMarcovecchioSubmitted almost 5 years ago
any thoughts on my solution? will make the change right away
@VincenzoMarcovecchioPosted almost 5 years agoHey Matt, thanks for your suggestion it is something i have to go back to
0