@Anas-95
Submitted
Vincent
@Vincent-Wirwicki
All comments
- Vincent• 160
@Vincent-Wirwicki
Posted
Your class naming is clear and the design is respected. Only the image is bit offset. A nice trick for images is to use Object-Fit propety and add a wrapper div arout it. Speaking of wrapper div, I think you can remove some of them. It would make the html easier to read. But it is only my personnal taste. It is a good work overall.
Marked as helpful
0 - Lyna• 260
@lynaIFR
Submitted
What are you most proud of, and what would you do differently next time?
I'm pretty satisfied with how the website came out, although I'll make sure to optimize the properties used to position the elements on the website.
What challenges did you encounter, and how did you overcome them?
When writing the CSS code I started using margins that would fit according to my screen, which is a bad way to do things, after looking I started learning about the flex properties in CSS that is way better to place elements.
What specific areas of your project would you like help with?
Feedbacks are welcomed, I would like to know if there is a better way to do the CSS reset, if you have any ideas on how to optimize the code please share them.
Vincent• 160@Vincent-Wirwicki
Posted
It looks good, and the code is clear. The only detail is that your card is not center. Probably because the footer tag is outside the main tag. If you wanna keep this html structure you can use css property position:absolute on your footer element and the card will be center.
Marked as helpful
0
