Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • Vikash Mauryaβ€’ 310

    @VikashMaurya10

    Posted

    Hey πŸ‘‹, you did a good job🎊. But there is a problem in mobile view, To solve :

    • Increase width of all card according to design.
    • Add correct border properties:
    .Luxury {
        border-bottom-left-radius: 11px;
        border-bottom-right-radius: 11px;
    }
    
    • I'm noticed hover on button of each card increased height of that card to solve it set border and its color is adjacent of card background. On button hover change background: transparent; :
        background-color: $Very-light-gray;
        padding: 1.1875rem 2rem;
        margin-top: 1.875rem; // 30px;
        border: 2px solid $Very-light-gray;
        outline: none;
        font-weight: 400;
        border-radius: 30px;
        cursor: pointer;
        font-size: 0.8rem;
        transition: background 0.1s ease-in;
    
        &:hover {
            background: transparent;
            color: $Very-light-gray !important;
        }
    }
    
    0
  • Vikash Mauryaβ€’ 310

    @VikashMaurya10

    Posted

    @code-nick, you did good job🎊. I want to draw your attention to some point:

    • Add transition property to make more smooth loading some other css.
    • Do't fix width create design, if you want to fix, use max-width or min-width.i.e
    card {
        background-color: hsl(217, 54%, 11%);
        box-shadow: 0px 0px 8px 10px rgba(0, 0, 0, 0.2);
        max-width: 350px;
        border-radius: 1rem;
    }
    
    • To make more accessible website follow this scenario:
    <html>
    <head></head>
    <body>
        <header></header>
        <main></main>
        <footer></footer>
    </body>
    </html>
    

    I hope you find helpful. To get more help please checkout my solution click here 🌐

    Marked as helpful

    1
  • Vikash Mauryaβ€’ 310

    @VikashMaurya10

    Posted

    Hey , you did a good job πŸ‘Œ. But add cursor: pointer; property into css.

    button{
            cursor: pointer;
    }
    

    Marked as helpful

    0
  • Vikash Mauryaβ€’ 310

    @VikashMaurya10

    Posted

    Hello there πŸ‘‹. You did a good job!

    • Hover on Button there is border so height and width increased of whole card. This is not well, you can do this
        background-color: $Very-light-gray;
        padding: 1.1875rem 2rem;
        margin-top: 1.875rem; // 30px;
        border: 2px solid $Very-light-gray;
        outline: none;
        font-weight: 400;
        border-radius: 30px;
        cursor: pointer;
        font-size: 0.8rem;
        transition: background 0.1s ease-in;
    
        &:hover {
            background: transparent;
            color: $Very-light-gray !important;
        }
    }
    
    • To understand better go to my solution maybe you can find it useful click here. I hope you find this helpful.
    0
  • Vikash Mauryaβ€’ 310

    @VikashMaurya10

    Posted

    Hello there πŸ‘‹. You did a good job!

    • Your code is good for desktop view but it's can't good for mobile view.
    • For design mobile view add CSS Media Queries.
    • Image alt text is used to describe your image textually so that search engines and screen readers can understand what that image is.
    • To understand better go to my solution maybe you can find it useful click here. I hope you find this helpful.
    0
  • Vikash Mauryaβ€’ 310

    @VikashMaurya10

    Posted

    Hello there πŸ‘‹. You did a good job!

    • Your code is good for desktop view but it's can't good for mobile view.
    • For design mobile view add CSS Media Queries.
    • You should not skip alt="" tag.
    • To understand better go to my solution maybe you can find it useful click here
    • I hope you find this helpful.
    1