All comments

• 

  P

  SMHN•200

  @smhnfreelancerSubmitted 8 months ago

  What are you most proud of, and what would you do differently next time?

  I used the Figma layout and I tried to do my best to match the result with the design.

  What challenges did you encounter, and how did you overcome them?

  Several challenges were kind of hard to achieve.

  1. I finally used width:66vw in the mobile screen size to make the whole card responsive in all sizes.
  2. I was pretty busy matching the width in the desktop screen size box-sizing:border-box fixed the issue.
  3. I used the exact font size and font properties, but my result was slightly different, so I set the desc class, font size to 17px; instead of 16px and got a better result.

  What specific areas of your project would you like help with?

  I think I need some help with the understanding difference between the results, even when you use the exact font and exact font-size and font properties. Also having a fully responsive card in all the mobile sizes made me to use 66vw as width of the card, but I think, there must be a better approach.

  

  Blog preview card - Pure CSS

  2

  20
  

  Vadim Pospelov•40

  @VH135Posted 8 months ago

  Hi there! Good effort on this chalenge.

  I see your desktop design excellent matches with the layout, congrats! Also you've added custom cursor pointer as shown in the layout, that's cool. And I like how you changed your styles to be more readable like this:

      <link
        rel="icon"
        type="image/png"
        sizes="32x32"
        href="./assets/images/favicon-32x32.png"
      />
  

  And there are some points woulbe great to improve:

  • Your mobile version of the card differs from the layout significantly.
  • Yours HTML classes like "tag" and "desc" are not informative. It woulbe be to name it like "card-tag", "card-desc", for example.
  • A couple of your lines of code starts with this symbol: >, it's not good in terms of readability.

  Hope you'll find this helpful.

  Marked as helpful

  1

  This comment has received 2 repliesShow
• 

  P

  Martin Mwaka•390

  @TemceoSubmitted about 1 year ago

  What are you most proud of, and what would you do differently next time?

  First attempt at QR code challenge

  What challenges did you encounter, and how did you overcome them?

  Centring the card.

  What specific areas of your project would you like help with?

  General review

  

  QR code component

  1

  30
  

  Vadim Pospelov•40

  @VH135Posted 9 months ago

  Hi, Martin! Good effort on this chalenge.

  There are some issues would be great to improve:

  1. Set the width to QR code picture to match the original design size
  2. Center heading and the text
  3. Move shadow from the text to the image and text container
  4. Use divs to structure HTML-markup with proper classes (heading, main-text, footer, etc.)

  Hope you'll find this helpful.

  0