@V0zmo
@bakellian
Submitted
What specific areas of your project would you like help with?
@V0zmo
Posted
Hello! Thank you for your feedback on my project. I also would like to give you feedback as my gratitude! Although Svitlana Suslenkova already answered your question. I would also like to share my approach to it, without changing the code and only adding some additional code.
No.1 - It seems like the reason the Learning tag taking that height is because of the margin. A simple fix could be done by adding this line of code.
.tag {
font-weight: bold;
color: #000;
margin: .2rem; /* ADDED */
}
You can modify it based on your preferences.
No.2 - For the image size it seems it doesn't cover the entire card-image-wrapper class. A simple fix could be done by adding this 4-line code.
/* ADDED */
.card-image-wrapper img{
width: 100%;
height: auto;
object-fit: cover; /* This is not necessary */
}
No.3 - For the image I can't quite be sure if it's the wrong size. But for me, it's already the perfect size.
You can check what goes wrong with the Inspect Element tool by pressing F12 (each browser sometimes has a different shortcut) or right-clicking the browser and selecting the Inspect Element option on the bottom list.
Overall a good code!🤩
@Ramon-Alvez
Submitted
What are you most proud of, and what would you do differently next time?
I'm proud of the responsiveness and especially the shadow box (this was new to me)
What specific areas of your project would you like help with?
I would like to know if I am doing unnecessary things and if my code is acceptable.
I'm still learning but I want to code like a pro.
@V0zmo
Posted
This is a good job well done! When I looked at your HTML code I learned something new, I didn't know that there Is <meta> tag data for information and good for search engines, I learned something new here! And I like how you use semantic HTML here nice! I didn't use it in mine since it broke the code and I'm too lazy to fix it lol.
However, if I must give feedback, I probably just use 1 CSS file instead of 3 different CSS files since this is a small project. However, if it's a bigger project then it's really good to start organizing! And I probably put my font in the CSS file to tidy it up with @import or @font-face. However, all of this is just an organizing preference.
And maybe add some of your variation or edit while done doing these challenges like mine have. I added a card hover effect, custom font, etc. (you can check mine if you want).
Overall a really good code and execution, great job!🤩
Marked as helpful
@Gingerlox
Submitted
What are you most proud of, and what would you do differently next time?
One good thing I used which I just recently learned is setting width and max width on my container/wrapper div, to keep it responsive, but also keep it from stretching at wider screens widths.
What challenges did you encounter, and how did you overcome them?
I found this fairly simple as I have just finished a CSS course, so concepts were still pretty fresh in memory.
What specific areas of your project would you like help with?
None on this, but can imagine help with be great for more complex projects.
@V0zmo
Posted
This is a fantastic code simple and easy to read for a beginner like me! Much cleaner than mine lol, responsive for any device, and also great for me to learn! If I have some feedback. Maybe add some other features of this solution, like some animation or other interesting things that involve deep knowledge of the CSS course that you learn. Other than that great job and thank you! 🥳🥳🥳
Marked as helpful
