All comments

• 

  Ankit Shaw• 10

  @ankitshaw1131

  Submitted over 1 year ago

  What do you think is the best way to center the div?

  

  QR Code component challenge

  5

  40

  

  User9511• 370

  @User9511

  Posted over 1 year ago

  Looks good!

  A small update I would make would be to update the following, This will make your project look more like the design.

  .container {
  max-width: 19rem;
  background-color: white;
  padding: 1rem;
  border-radius: 18px;
  text-align: center;
  margin: 0 1em;
  }
  

  0
• 

  User9511• 370

  @User9511

  Submitted almost 2 years ago

  

  Fylo Landing Page with two-column layout

  2

  10

  

  User9511• 370

  @User9511

  Posted over 1 year ago

  Thanks for the feedback Grace! :)

  I've updated my code now,

  Let me know if there are any other changes you think I shoud make.

  Thanks, Shane

  0
• 

  sohail ebada• 100

  @sohailebada

  Submitted almost 2 years ago

  If you have any suggestions to improve the solution, don't hesitate to tell me in the comments below

  

  order-summary-component-main

  1

  20

  

  User9511• 370

  @User9511

  Posted almost 2 years ago

  Looks really good!

  The only thing I can see that you are missing

  .payment a {
          text-decoration: underline;
  }
  
  .payment a:hover {
           color: var(--Bright-blue);
  }
  

  0

  This comment has received 1 replyShow
• 

  Marcos• 40

  @Toxgem

  Submitted almost 2 years ago

  -Is the code clean enough? -What changes should i be doing to keep best practices? -What would be your approach to this challenge? I wonder what other ways are to clear this one, maybe the usage of buttons, and how many tags i am missing to make it simpler.

  

  Interactive Rating Component Vainilla JS

  2

  40

  

  User9511• 370

  @User9511

  Posted almost 2 years ago

  I would change your .container to this

  .container {
          max-width:25rem;
          background:linear-gradient(14deg, rgba(23, 30, 40, 1) 0%, rgba(33, 40, 50, 1) 90%);
  }
  

  1
• 

  Kapil Rohilla• 190

  @Kapilrohilla

  Submitted almost 2 years ago

  finally completed after a long break

  

  News Home Page Main Solution

  1

  30

  

  User9511• 370

  @User9511

  Posted almost 2 years ago

  Unable to view your project.

  Firefox says it's a dangerous potentially phishing website.

  0

  This comment has received 1 replyShow
• 

  Akash Nagindar Tayde• 150

  @19akasht

  Submitted about 2 years ago

  Please help me if there is any problem with my code. Thank you

  

  clipboard-landing-page-master

  1

  20

  

  User9511• 370

  @User9511

  Posted about 2 years ago

  Hey Akash Nagindar Tayde,

  You are missing the active hover states on your buttons.

  This is how I would solve that issue by creating a new variable in the :root:

  :root {
        --Lighter-Blue: hsl(233, 100%, 78%);
  }
  

  btn btn-blue:hover {
        background-color: var(--Lighter-Blue);
  }
  

  You should also add a hover state for the links in the footer:

  footer p:hover {
       color: var(--Strong-Cyan);
  }
  

  Also, the footer links should be in an unordered list using this syntax:

  <footer>
       <ul>
            <li></li>
            <li></li>
            <li></li>
            <li></li>
            <li></li>
       </ul>
  </footer>
  

  Marked as helpful

  0