All comments

• 

  Better5afe•850

  @better5afeSubmitted over 1 year ago

  

  React.js + TypeScript + Custom Hook + SCSS Newsletter Sign-up Form

  #accessibility#react#sass/scss#typescript#bem

  1

  80
  

  Dario Rodrigues•160

  @UnidadePosted over 1 year ago

  I loved your animations; they were such a great addition to the challenge. Overall, I think it's a pretty solid implementation, and in terms of code, it's well-written and easy to navigate.

  I'm curious about how much time you spent on this challenge

  0
• 

  Mohamed Sayed•290

  @msabdalaalSubmitted over 2 years ago

  

  IP Address Tracker | React & TailwindCss

  #tailwind-css#react

  2

  20
  

  Dario Rodrigues•160

  @UnidadePosted over 2 years ago

  I looked your javascript code and I found that you a are making more fetch calls than the necessary, I inspected this with the network section on devTools. This is an example that are present in your components:

  {fetchLocation(ip).city}, {fetchLocation(ip).country}
  

  The response of this fetch call is a data object that have all the properties that you are accessing, you can be more efficient if you store the fetch data in a variable and access them as need. For example, this only make a fetch call.

  const data = fetchLocation(ip)
  {data.city}, {data.country}
  ...
  

  This is important because you don't want to make unnecessary call to the server, they can bottleneck your app, you are using more of your api call quotes and isn't efficient at all.

  Marked as helpful

  1