All comments

• 

  MarioP•30

  @quijotexSubmitted over 1 year ago

  How can I enhance my code? How can I write my code including good practices? How can I make my code cleaner and shorter?

  

  Responsive solution for the first challenge using CSS Flexbox

  2

  60
  

  Umut Yılmaz Gündüz•150

  @UmutYGPosted over 1 year ago

  Hello there, Congrulations for the amazing work! I have some tips for you for a cleaner code:

  • Consider applying given font-family on the body to get a better matching design! (Use google fonts if needed)
  • Use rem unit instead of pixels, later this will help you to build responsive websites easily.

  @media screen and (min-width: 576px) {
  .main {
  display: flex;
  justify-content: center;
  }
  .main_div {
  width: 65%;
  height: 65%;
  }
  }  
  @media  screen and (min-width: 768px) {
  
  .main {    // => NOT NEEDED
  display: flex;
  justify-content: center;
  }
  .main_div {
  width: 40%;
  }
  }
  

  When using queries, you do not need to apply same css on the rules apply at the same time, for example, at the 800 px width both of the queries apply so you do not need to apply same css rules for the main, you can just focus on different and more special css rules. I hope this helps! Good luck and good job!

  Marked as helpful

  0

  This comment has received 1 replyShow