Skip to content
OverviewSolutions
6
Comments
3
TomasAlbert
@TomasAlbert

All comments

  • TomasAlbert•120
    @TomasAlbertPosted 12 months ago

    I would suggest you to use details and summary html elements. You solution works but if you try navigate with tab its not working. For better accesibility you can these native elemnts or try to implement it with js.

    1
  • JPacademico•10
    @JPacademicoSubmitted 12 months ago

    had to separate the text in paragraphs because it was easier for me to centralize

    Basic html and css

    1
    TomasAlbert•120
    @TomasAlbertPosted 12 months ago

    Hi congrats, for completing this challenge i saw you solution for centering text i think you make you life harder then it should be you can just use <br> tag which will brake line and use text-align: center property and you will get same result. So you can replace this code

    <div class="second-p"> <p>Scan the QR code to visit Frontend</p> <p>Mentor and take your coding skills to</p> <p>the next level</p> </div>

    with this

    <p style=" margin-top: 18px; text-align: center; color: #9a9aa0; font-size: 14px; ">Scan the QR code to visit Frontend <br> Mentor and take your coding skills <br> to next level</p>

    Or you can just use padding for you p-tag.

    0
  • TomasAlbert•120
    @TomasAlbertPosted 12 months ago

    Hi, congrats for completing this challenge ! Your code seems well structured. Just for ingormation there is <picture> element which can be used to display image depending on screen so you dont need to do it in css. You can also look at <s> element which will be semanticly better in my opinion you can even wrap ip into <span>.

    Marked as helpful
    1