Skip to content
OverviewSolutions
10
Comments
8
TheTrueScout
@TheTrueScout

All comments

  • TheTrueScout•130
    @TheTrueScoutPosted 13 days ago

    There's this little trick i learnt from youtube- using addEventListener('keyup', () => {}) to make the input update in real time and remove the error message after putting in a vald email. Looks great, cheers!

    1
  • TheTrueScout•130
    @TheTrueScoutPosted 17 days ago

    ah yes, i'm forced to give feedback on the code of someone better than me wkwk. Very cool how you made your script thing in only 12 lines though lol. I have a long way to go :v

    0
  • EfthymiosK•180
    @EfthymiosKSubmitted about 2 months ago
    What specific areas of your project would you like help with?

    In the design comparison my solution looks different than the design (upper paragraph is narrower in the first testimonial), but on the github live page and on my live server it looks right. When I was writing the CSS code I tried to use rem units for the font sizes but for some reason it didn't work so I had to use pixels. Any ideas?

    Solution using CSS Grid and Flexbox

    1
    TheTrueScout•130
    @TheTrueScoutPosted about 2 months ago

    i think your font size for the header is slightly bigger, and maybe you could play with padding for the (upper paragraph is narrower in the first testimonial), . Great job though, i love it :)

    1
  • TheTrueScout•130
    @TheTrueScoutPosted about 2 months ago

    looks better than mine honestly :) but my only suggestion would be adding clamp(min value, preferred value, max value) for headers so it scales down the font size and fits perfectly on mobile( i haven't put that on mine yet either tbh haha ). Great job!

    0
  • TheTrueScout•130
    @TheTrueScoutPosted 2 months ago

    looks pixel perfect to me! I find it hard to do that haha :) Good job!

    0
  • TheTrueScout•130
    @TheTrueScoutPosted 2 months ago

    Is it made for mobile? the font aside, it looks good on mobile(although it doesn't match the mobile design, but you need to add a design for bigger screens too :)

    0
  • Daniel•240
    @DAJ350Submitted 2 months ago
    What are you most proud of, and what would you do differently next time?

    I'm proud of how closely I was able to recreate the design using based of the provided Figma design file.

    What challenges did you encounter, and how did you overcome them?

    I had a slight challenge figuring out how to achieve the tablet and mobile dimensions but was able to overcome this using a couple media queries.

    What specific areas of your project would you like help with?

    I'm open to suggestions.

    Social Links Profile built with HTML and CSS

    3
    TheTrueScout•130
    @TheTrueScoutPosted 2 months ago

    Someone suggested this to me, and I think it'll help you too :) it'll make your card more responsive.

    .card {
width: 90%;
max-width: 37.5rem;
}
    0
  • TheTrueScout•130
    @TheTrueScoutPosted 2 months ago

    It looks like you set a height on the container. Sometime's that's bad practice because you limit things unnecessarily. Remove the height, and add more padding to the bottom and you'll be a'ok.

    I just looked at the live site, and it looks like that has already been fixed- which is good. ( the code still has a fixed height, but if it works, it works :). )

    Learn how to use flex boxes. It will make your life much easier.

    You can use margin: 15px 0 15px 0; in order of Top, Right, Bottom, Left instead of using margin left, or margin top on separate lines.

    Styling the image is unnecessary. adding a border radius is enough.

    You didn't add the designated challenge font.

    0