Skip to content
OverviewSolutions
2
Comments
2
Adriana Peña
@ThePinkGargoyle

All comments

  • Adriana Peña•40
    @ThePinkGargoylePosted 4 months ago

    Hello, Mugesh C,

    I'm impressed that you used react. I have enough trouble with HTML, CSS, Flex, and CSS Grid. I wasn't able to see the code because the link wasn't working, but I'm curious to see how you used react in you solution.

    Here are the answers to the questions above:

    Does the solution include semantic HTML? Unknown

    Is it accessible, and what improvements could be made? Unknown

    Does the layout look good on a range of screen sizes? The Layout looks good, but the solution is responsive and was a bit larger than the design. I couldn't see the code, it could have been my browser.

    Is the code well-structured, readable, and reusable? Unknown

    Does the solution differ considerably from the design? No

    0
  • Adriana Peña•40
    @ThePinkGargoylePosted 4 months ago

    Hello, f-lebouc,

    I really liked your design and code. Your code was clean and flowed - making it easy to read. I liked how you used internal CSS, I think for this simple qr-code project it was the best way to execute it (it would make it easier to add as an element in html email code).

    Here are the answers to the questions above: Does the solution include semantic HTML? Yes Is it accessible, and what improvements could be made? I did not see aria landmarks, but I feel the code was concise. Does the layout look good on a range of screen sizes? Yes Is the code well-structured, readable, and reusable? Yes Does the solution differ considerably from the design? No

    Marked as helpful
    1