@jarherSubmitted 11 months ago
P
ThabisoMagwaza
@ThabisoMagwazaAll comments
- @ThabisoMagwazaPosted 11 months ago
Absolutely incredible solution. I love how you handled the styling of the decorative blobs, very good.
Your Desktop and mobile designs are great, but I don't think that you gave much thought to the tablet designs. Although the tablet designs are not given in the Figma document, I think that it's worth it to spend a bit of time thinking and catering for it. It'll be a nice challenge.
Also, please pay carefull attention to spacing (margins, padding) and alignement. There are subtle differences between the different form factors and training your eyes to notice that will make you an even better front-end developer.
Marked as helpful0 - @enzo-mirSubmitted 12 months ago
🕓≈ 6h Api : search for an other api beacause cleanuri Api doesn't work there is a problem with
corsas if you use theno-corsmode it's maybe broken :(- I used instead url-shortener-service
@ThabisoMagwazaPosted 12 months agoThis is very nice solution. I'm impressed that you managed to do it with vanilla html and CSS.
I woud, however, caution against straying from the design when implementing such challenges. It's an interesting test of your attention to detail when you attempt to get the final application to look as close to the design as possible.
These are some of the areas I've identified where you strayed from the design:
- Some button and links hover states are incorrect
- The font sizes and whitespaces are not as per design
- The hero image is quite small compared to the design
Additionally, I'd look into disabling the button when call to the url shortening is in progress. I found myself mistakenly clicking the button twice. It would also help to have some kind of loading indicator.
I'm sure you can find some more. I suggest that you look throught the design again while paying close attention to the whitespace, hover and active stetes.
You have an impressive grasp of CSS and I'm sure you'll benefit from the challenge!
Marked as helpful1 - @czBalazs98Submitted 12 months ago@ThabisoMagwazaPosted 12 months ago
This is very nice solution. I love how you added error handling and the delete button on each url. Those were nice touches!
I woud, however, caution against straying from the design when implementing such challenges. It's an interesting test of your attention to detail when you attempt to get the final application to look as close to the design as possible.
These are some of the areas I've identified where you strayed from the design:
- Some button and links hover states are incorrect
- The font sizes and whitespaces are not as per design
- The mobile navigation is missing and the mobile design is broken
I'm sure you can find some more. I suggest that you look throught the design again while paying close attention to the whitespace, hover and active stetes.
You have an impressive grasp of CSS and I'm sure you'll benefit from the challenge!
0 - @imparassharmaSubmitted 12 months ago
This task was looking like a piece of cake but it was challenging. Good amont of css is required to complete the task [my style.css was about 1000lines :) ] . My main objective was to follow a good approach and make it as responsive as possible. I know there are more things to learn but I followed %,rem units. Any suggestions about how can I improve further are welcome.
@ThabisoMagwazaPosted 12 months agoThis is very nice solution. I love how you got some of the complicated styling correct.
I especially found your treatment of the images very impressive. But like you said, there's certainly room for improvement.
These are some of the areas I've identified where you strayed from the design:
- Some polish on the fonts. It looks too bit and too bold on some screen sizes
- You might wanna look add the correct metadata i.e favicon and title
- Your decorative blob doesn't seem to respond too well as I resize the page
I'm sure you can find a lot more. I suggest that you look throught the design again while paying close attention to the whitespace, hover and active stetes.
You have an impressive grasp of CSS and I'm sure you'll benefit from the challenge!
Marked as helpful0 - @Ko-Win-LwinSubmitted 12 months ago@ThabisoMagwazaPosted 12 months ago
This is very nice solution. I love how you got some of the complicated styling correct.
I woud, however, caution against straying from the design when implementing such challenges. It's an interesting test of your attention to detail when you attempt to get the final application to look as close to the design as possible.
These are some of the areas I've identified where you strayed from the design:
- The font looks too small
- Your decorative blob doesn't seem to be responsive. It breaks on some screen sizes
- Validation and layout on the contact form doesn't look correct
I'm sure you can find a lot more. I suggest that you look throught the design again while paying close attention to the whitespace, hover and active stetes as well as any error states on forms e.t.c
You have an impressive grasp of CSS and I'm sure you'll benefit from the challenge!
Marked as helpful0 - @personaluigiSubmitted 12 months ago@ThabisoMagwazaPosted 12 months ago
This is very nice solution. I love how you got some of the complicated styling correct.
I woud, however, caution against straying from the design when implementing such challenges. It's an interesting test of your attention to detail when you attempt to get the final application to look as close to the design as possible.
These are some of the areas I've identified where you strayed from the design:
- Button and links hover states
- Missing decorative blob on the features section
- Contrained max-width on the content
I'm sure you can find a lot more. I suggest that you look throught the design again while paying close attention to the whitespace, hover and active stetes as well as any error states on forms e.t.c
You have an impressive grasp of CSS and I'm sure you'll benefit from the challenge!
Marked as helpful1 - @kingoudSubmitted about 1 year ago
this challenge will help more on becoming an industry standard developer
@ThabisoMagwazaPosted about 1 year agoGood job on getting this far but this looks very muck like a work in progress. The styling and functionality don't quite resemble what was given in the brief. Please make sure to complete all aspects of the project before you can consider it as done.
0 - @LocoyoccimSubmitted about 1 year ago
First Tailwind project
@ThabisoMagwazaPosted about 1 year agoVery good job with the challenge. Very good job.
The functionality is certainly there but I think you need to pay a bit more attention to detail when it comes to the styling. Your whitespace, especially on Desktop, doesn't look correct.
0
