@TCO932Submitted 2 months ago
Terez Lagova
@TerezLAll comments
- @TerezLPosted about 2 months ago
Great job! your code works really well, only issue is that your product picture is not align properly and covers navbar a little bit. overal you did a great job
0 - @srijanssSubmitted 3 months agoWhat are you most proud of, and what would you do differently next time?
- I learned about different aria attributes and its use cases
- I learned about the transition CSS property that I used for opening and closing the nav menu
- I also learned about how to set and remove focus on the element programatically using tabindex
I had some issue with remove focus on nav links when nav is not visible on mobile devices. Then I found out that settings tabindex = -1 will not focus the element and this can be done using JS. And for screen readers we need to set aria-hidden attribute to true.
What specific areas of your project would you like help with?Any feedback is welcome, especially regarding the a11y
@TerezLPosted 3 months agoGreat job! your design is spot on and code easy to read. Keep going!
1 - @fsahinbasSubmitted 3 months ago
- @SouhailM07Submitted 10 months ago
- @sudhanshusingh-gSubmitted over 1 year ago@TerezLPosted 3 months ago
Great job! Works as it should and you have clean, easy to read code
0 - @Ridwan10000Submitted 3 months agoWhat challenges did you encounter, and how did you overcome them?
I found this project a little bit tricky. Working with vanilla JS is quite hard. Also I learned that styling document via JS is not a good approach. Rather I should create CSS rules and add them to elements via JS on some event.
What specific areas of your project would you like help with?Suggestions regarding to code optimization is appreciated. I know I have made a mess of my code. Also I know I used wrong mark-ups.
@TerezLPosted 3 months agoGood job! You are right vanilla JS is really tricky. You did very well, only things you should look for are your inputs where there is "0" added at the end whenever typing
0 - @Kelvin-BenSubmitted 4 months agoWhat are you most proud of, and what would you do differently next time?
The project was quite small but interesting because I practiced fetching Data and also adding functionalities using JavaScript.
What challenges did you encounter, and how did you overcome them?I encoutered several challenges but the most obvious was fetching data and displaying it. I had to dig deeper to undestand the idea behind working with data.
What specific areas of your project would you like help with?Nothing so far, Though I will put more effort to understand css grid.
@TerezLPosted 3 months agoGood job, you did well fetching data. Your grid works properly as well
Marked as helpful1 - @Mohammed-NedjimaSubmitted 4 months ago
- @Obom23Submitted 4 months agoWhat specific areas of your project would you like help with?
Any feedback is appreciated
- @vvvasaviiSubmitted 4 months agoWhat specific areas of your project would you like help with?
how can i make the 4 cards smaller in width,similar to the design?whenever i use the grid template column for it it just wasnt doing what i intended it to do. any help is greatly appreciated
- @TimilovicSubmitted 4 months ago
- @SamuelSY01Submitted 4 months ago
