@TechEdDan2
@Fafell
Submitted
What are you most proud of, and what would you do differently next time?
I added hover to the link buttons to make them look better
What challenges did you encounter, and how did you overcome them?
It wasn't difficult, but I practiced styling in CSS
What specific areas of your project would you like help with?
I'm wondering if I'm using units correctly
@TechEdDan2
Posted
Your code is well-structured, and easy to read. I like the use of an active pseudo-class on the buttons, a really nice addition. It looks like we both approached the challenge in similar way, structureally. It looks like you are using the right units for everything. Maybe you could use more relative units for padding rather than absolute pixel values, but I am not a professional, so I am not sure if that is a good suggestion. Nice work!
Marked as helpful
@meher-hex
Submitted
What specific areas of your project would you like help with?
I faced a great challenge in rounding the corners of the SVG file and sadly, I haven't overcome it yet. According to the given asset and design preview, the illustration should have round corners but I can't round the corners. As per my knowledge, CSS styles don't work on SVG files like that. I can't even work around it. I'm open to suggestions.
@TechEdDan2
Posted
Hello,
Nice work. Just a quick FYI, the link to your solution's "view code" actually goes to your QR Code solution, so you might want to update the info. When I looked at your solution in the other repository, I noticed you didn't get to add the active state for the "HTML & CSS Foundations" text. To do this, you could use the class selector "title" you assigned the <p> element with the text in it and add the pseudo class hover. The syntax would look something like this:
.title: hover{ color: yellow; cursor: pointer;}
Hope this helps!
@tatyanepgoncalves
Submitted
What are you most proud of, and what would you do differently next time?
Esse projeto foi realizado usando Grid que é um tópico que ainda não tenho prática. O resultado ficou um pouco parecido com o da imagem.
What challenges did you encounter, and how did you overcome them?
Minhas dificuldades foram em grid-template-columns e grid-template-rows.
What specific areas of your project would you like help with?
Gostaria de dicas de como organizar melhor os elementos utilizando os comandos acima.
@TechEdDan2
Posted
Perdón por escribir en inglés, pero deberías poder utilizar el traductor integrado de Chrome.
I used Flexbox to create my project, so I do not know how helpful I can be with grid... I am also learning to be more comfortable with it, too. I tried experimenting with your .team{ grid-row: 1; grid-column: 2; } and .karma{ grid-row: 3; grid-column: 2; } class selectors, but couldn't get the centering of the cards to quite work. Have you checked out https://css-tricks.com/snippets/css/complete-guide-grid/ as a resource? I also really liked watching Kevin Powell's videos, like: https://youtu.be/8QSqwbSztnA?si=_a5qbm0rswUVVAXr or https://youtu.be/rg7Fvvl3taU?si=cHi2dcHCp6OotGjD where he goes over a Frontend Mentor Project using grid. Good Luck!
@legendofnoobs
Submitted
What are you most proud of, and what would you do differently next time?
lol
What challenges did you encounter, and how did you overcome them?
lol
What specific areas of your project would you like help with?
lol
@TechEdDan2
Posted
Nice work on the project. The HTML is very clean and easy to read. I used a similar approach to creating my solution. However, I am unfamiliar with the -<uniquifier> that you used at the top of your CSS. Is this part of a change to using Google Fonts with CSS classes? Thanks for teaching me something new.
@Lemon-stack
Submitted
I'm not 100% sure of responsitivity in different view ports
@TechEdDan2
Posted
Hello,
Nice work on the desktop version.
A suggestion for helping with the mobile version might be to give your div with the .ctn class attribute a fixed px width as soon as you hit the break point you set for the media query, so everything will switch to a mobile view with the image and text content (inside of your hero div) all being the same width size. From 769 until 370 the hero section stretches to the edge of the ctn div. I might also recommend using 100% for the image size, but others might say not to. Hope this helps!
Best of luck!
Marked as helpful
@MartinsitoBritoDiaz
Submitted
Hi, any feedback is welcome
@TechEdDan2
Posted
Nice Job! I had an issue with getting the background right, too.
