Skip to content
OverviewSolutions
2
Comments
3
Taro Chilongoshi
@Tchilo

All comments

  • Taro Chilongoshi•40
    @TchiloPosted about 2 years ago

    Hi @MedAmineCk

    Great solution!!!. There is little to no difference from the original design. I do have a few suggestions for you that you can consider adding to your code:

    Use <main> instead of a simple <div> this way you improve the semantics and accessibility showing which is the main block of content on this page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning. The main heading has the tag <h3>, in this case, you should replace it with <h1> since this heading is the main title on this page. Remember that every page should have one <h1> to declare which is the most important title and that you should follow the hierarchy using the heading sequence (h1, h2, h3, h4, h5) and never jump a level.

    Here is an article on freecodecamp on semantics I hope it helps out: Semantic HTML5 Elements Explained

    ✌️ I hope this was helpful and happy coding!

    Marked as helpful
    1
  • Taro Chilongoshi•40
    @TchiloPosted about 2 years ago

    Hi @whyski008

    Great solution and a great start! From what I have seen you’re on the right track. Here are a few suggestions for you that you can consider adding to your code:

    Use <main> instead of a simple <div> this way you improve the semantics and accessibility showing which is the main block of content on this page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning. The main heading has the tag <h3>, in this case, you should replace it with <h1> since this heading is the main title on this page. Remember that every page should have one <h1> to declare which is the most important title and that you should follow the hierarchy using the heading sequence (h1, h2, h3, h4, h5) and never jump a level.

    Here is an article on freecodecamp on semantics I hope it helps out: Semantic HTML5 Elements Explained

    ✌️ I hope this helps you and happy coding!

    0
  • Taro Chilongoshi•40
    @TchiloPosted about 2 years ago

    Hello, Geovany Gonzalez fantastic work you have done there I love the use of the variables and your CSS is neatly written. the cards have been positioned perfectly unlike mine hahaha you can take a look at mine here: https://www.frontendmentor.io/solutions/fourcardfeaturesection-kd4J2ee95n

    I would kindly suggest that you take a look at the following:

    • Kindly add some padding on the left and right sides of the mobile view as it has on the tablet view. You can add some padding to this class -> .cardscontainer

    the following are a little different from the design:

    • font size
    • font-weight
    0