all feedback is welcomed
Samuel Sylvester
@Sylvester009All comments
- @MarijanjghhavaSubmitted 6 months agoWhat are you most proud of, and what would you do differently next time?
- @grace1999-pixelSubmitted 7 months agoWhat challenges did you encounter, and how did you overcome them?
I found it challenging to make the svg the back ground. Also to bring the purple box div to the bottom. I tried to do it with flex but it was getting in the way of other div tags. Finally used , absolute and relative positioning.
@Sylvester009Posted 7 months agoHello, you got the design properly well done but there is no JavaScript in your work. Hence you only have a static page. I advise you add JS to your code so that your design aligns with the original design.
Marked as helpful0 - @Lbaranda26Submitted 7 months ago@Sylvester009Posted 7 months ago
Nice work here, to complete the whole setup for the desktop, try to make it possible for the share modal to open and close when the share button is clicked. Use can do by putting an if statement inside the function of the EventListener, something like this: desktopShareButton.addEventListener("click", () => { if (desktopShareModal.style.display === "flex") { desktopModalIsClose(); } else { desktopModalIsOpen(); } });
0 - @Silzzz0717Submitted 7 months ago@Sylvester009Posted 7 months ago
Hello @Silzzz0717, you have done a fantastic job and got your centering properly. Only if changes has to be made and your will be good to go. If you try working on the font size, color of your text, I bet you love it better and also add a bit of padding around the text as you work on the font to make more appealing. Overall, you have a good grasp of semantic coding, welldone.
0 - @matbac85Submitted 7 months agoWhat are you most proud of, and what would you do differently next time?
I'm happy to have reached the end of this challenge. At this stage, I don't know what I would have done differently.
What challenges did you encounter, and how did you overcome them?I had difficulty positioning the elements because of the extra content that appears when you click on the "more" button. Initially, I'd coded my entire layout without taking this into account and then, when I finally integrated it, I realised that I couldn't use padding on the parent container and that I'd (perhaps) have to use margins. At this stage, I'm not sure that's the best way to do it. I'm a bit disappointed because (and I don't know what my learner peers think), but sometimes I feel confident in HTML and CSS and the next moment I can't get the result I want properly and I'm doubting again.
What specific areas of your project would you like help with?If you've worked on this project differently for the positioning of the elements, I'd be happy to know how and why. Thanks in advance!
- @anyuba123Submitted 7 months agoWhat are you most proud of, and what would you do differently next time?
doing good
What challenges did you encounter, and how did you overcome them?location of items
What specific areas of your project would you like help with?with grid
@Sylvester009Posted 7 months agoWhat excellent work you are doing, keep it up. In regard to needing help with the CSS grid, if you don't mind me recommending "w3schools" for you, you can check out their teachings on CSS grid because it has also helped me a lot in my understanding of grid.
0 - @makiheroSubmitted 10 months agoWhat are you most proud of, and what would you do differently next time?
none
What challenges did you encounter, and how did you overcome them?none
What specific areas of your project would you like help with?none
- @KahSRSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
.
What challenges did you encounter, and how did you overcome them?.
What specific areas of your project would you like help with?.
- @JamesWallison1Submitted 7 months ago@Sylvester009Posted 7 months ago
I must say that apart from the center alignment, your work really showcases your understanding of HTML and CSS. Try using margin or flexbox to center your container and you are good to go.
Well done...
Marked as helpful0 - @brainkaSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
I am proud that I am completing the challenges quicker each time.
What challenges did you encounter, and how did you overcome them?Ensuring that flex box resizes correctly on mobile view.
What specific areas of your project would you like help with?Feedback on overall solution and if there are better ways of doing css.
Thank you
- @duw-altSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
.
What challenges did you encounter, and how did you overcome them?.
What specific areas of your project would you like help with?.
- @Dami-OlusSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
Having learnt the basics of HTML, CSS and JS for a while now, I am proud to start using it to build in public. It was pretty easy and I look forward to bigger challenges. As this project was easy I did not see any need to use any frameworks
What challenges did you encounter, and how did you overcome them?As a starter project this was pretty straight forward and easy. My goal is to build up a steady habit of coding almost everyday
What specific areas of your project would you like help with?Having an eye for pixel and design is an area I want to develop
@Sylvester009Posted 7 months agoOverall, I must commend you for your excellent grasp of CSS. The use of understandable class names is very commendable. Also, the novelty in which you styled your title and paragraph shows that you have spent time understanding how to style.
Excellent work, sir.
0