P
Rohan Tayal• 310
@rohantayal
Submitted
Stephanie0905
@Stephanie0905
All comments
- Stephanie0905• 210
@Stephanie0905
Posted
You do very well with the design but the js part doesn't fit well. First of all, the application should not "Cannot be zero" upon loading. The user must try to enter zero for the app to return this message. Secondly the total / person does not display anything, i suppose that the upstream calculation was not done and finally the reset button must work on the entire form, not just on the inputs.
0 - Sergiy• 880
@MrSeager
Submitted
Stephanie0905• 210@Stephanie0905
Posted
Good job!!
1 - Caio Almeida• 120
@caioalmeidacl
Submitted
Stephanie0905• 210@Stephanie0905
Posted
The capture of your design looks exactly like the capture of the challenge. But your site in live isn't fully responsive. You need to adjust this part and it's gonna be perfect
Marked as helpful
0 - Shiv• 350
@undrthegraveyard
Submitted
What are you most proud of, and what would you do differently next time?
I am pretty happy with it, since I was able to implement accessibility in this one by using proper image alt text, aria labels, and include keyboard accessibility. 😁
What challenges did you encounter, and how did you overcome them?
This particular challenge was part of the JS Fundamentals learning path. The main challenge I encountered was with the logic itself, but I finally did it after a couple of days. ✌🏻
What specific areas of your project would you like help with?
I would love the community's feedback on accessibility. I have included ARIA labels, alt descriptions, and made it keyboard accessible. 💪🏻
Stephanie0905• 210@Stephanie0905
Posted
Nice work your design fits very well !!!
0 - PHicham Abderrahim• 210
@hichamweblog
Submitted
What are you most proud of, and what would you do differently next time?
I am most proud of successfully implementing a fully responsive testimonials grid section that adapts seamlessly to various screen sizes.
What challenges did you encounter, and how did you overcome them?
One major challenge was using CSS variables to manage the colors and backgrounds for each testimonial card using HSL values.
Example from the code:
:root { --clr-primary: 263, 55%, 52%; --clr-secondary: 217, 19%, 35%; --clr-white: 0, 0%, 100%; } .testimonial-card { color: hsl(var(--clr)); background-color: hsl(var(--bg)); } .testimonial-card:nth-of-type(1) { --clr: var(--clr-white); --bg: var(--clr-primary); }What specific areas of your project would you like help with?
Are there any areas in my HTML or CSS where I can improve code quality, readability, or maintainability? Specifically, any feedback on the structure and organization of my CSS would be appreciated.
Stephanie0905• 210@Stephanie0905
Posted
Good job!! Your design is perfect. Well done!
1 - Raptor0x1• 210
@Raptor0x1
Submitted
What challenges did you encounter, and how did you overcome them?
Using grid layout for the first time was difficult but eventually I got the hang of it. I asked in the discord server.
What specific areas of your project would you like help with?
How to make the width of paragraph of the heading class smaller in screen sizes greater than 1024px?
Stephanie0905• 210@Stephanie0905
Posted
Good job. I appreciate the fact that you use Grid because many of us have used Flexbox. You're doing great!
0 - Shreyas235• 80
@Shreyas235
Submitted
Stephanie0905• 210@Stephanie0905
Posted
Good job! You can do better if you add media queries. I know from my personal experience that can be difficult but it's help me for this challenge, so try it and good luck for the rest of the challenge.
Marked as helpful
0 - AlienInvade• 160
@AlienInvade
Submitted
What are you most proud of, and what would you do differently next time?
Being able to complete this project, it wasn't easy for me hence being able to complete it makes me proud of myself.
What challenges did you encounter, and how did you overcome them?
changing the colors of the list markers, I wasn't aware of the fact that they can be customized by researching about it online shed the light on my problem.
What specific areas of your project would you like help with?
n/a
Stephanie0905• 210@Stephanie0905
Posted
Good job, you doing great. Continue like that!!!
0 - MR.White• 40
@ThisWhiteYa
Submitted
Stephanie0905• 210@Stephanie0905
Posted
Good job!!!!
0 - errbrokko• 80
@errbrokko
Submitted
Stephanie0905• 210@Stephanie0905
Posted
Good job! I like the fact that you use media for the responsivity of the card. Little tip to avoid the appearance of the bar uses overflow: hiden; in the body and it will be hidden.
Marked as helpful
1 - errbrokko• 80
@errbrokko
Submitted
Stephanie0905• 210@Stephanie0905
Posted
It's impossible to see your live site and your repository doesn't contain any file
0
