Skip to content
OverviewSolutions
5
Comments
4
Noel
@StConstantineCole

All comments

  • Noel•110
    @StConstantineColePosted over 2 years ago

    Thanks a lot for the tips I’ll be implementing these changes, always happy to learn better ways to to write code

    0
  • Noel•110
    @StConstantineColePosted over 2 years ago

    The "Learn more" button affects the spacing of the page (It moves the paragraph up whenever it is hovered) This is because the border which is triggered on hover takes up space.

    Solution: Apply the border on the "Learn more" button in its normal state but make the same color as the background then on hover just change the color of the border to desired color, that way the space for the border is already accounted for.

    This will eliminate any movement of hover.

    Marked as helpful
    1
  • Noel•110
    @StConstantineColePosted over 2 years ago

    One issue the I've had and that I've seen with other submissions of this project is that if you expand the page/screen size while the mobile menu is open the mobile menu will still be visible in desktop mode/view (You can test this in developer tools).

    Solution (For me): window.onresize = function(){ location.reload(); }

    use that line of code to refresh the page whenever the window resizes.

    Great project !!!

    Please feel free to review mine.

    1
  • Noel•110
    @StConstantineColePosted over 2 years ago

    Really great submission, the responsiveness of your site is very good, that's an area that I struggled with, feel free to review my submission of this project. Some tips would be greatly appreciated.

    1