Skip to content
OverviewSolutions
6
Comments
9
Shams Wali Sowmo
@Sowmo0509

All comments

  • Shams Wali Sowmo•130
    @Sowmo0509Posted over 2 years ago

    Hello Luis! Nicely done! But you can see, the image doesn't load at all. Because, your path is defined as /primer desafio pagina qr/qr-code-component-main/images/image-qr-code.png which is not found on your website/hosting. That's why the image is unable to load. Try to add ./ before the path, something like ./primer desafio pagina qr/qr-code-component-main/images/image-qr-code.png this. Avoid using spaces when creating a folder, do not use primer desafio pagina, use primer-desafio-pagina or primer_desafio_pagina instead from the next time! Hope it works out.

    0
  • Shams Wali Sowmo•130
    @Sowmo0509Posted over 2 years ago

    Hello Ruqayya, once again- amazing! But this QR code component seems not quite responsive enough. When you resize the browser window, you'll notice, things are breaking and on mobile it doesn't look good enough or responsive. Regards.

    0
  • Shams Wali Sowmo•130
    @Sowmo0509Posted over 2 years ago

    Heyy Ruqayya! Nicely done! I understand it's been a while you haven't worked with plain CSS, but there's something you should look at. Check the button on desktop preview. The texts are breaking, that's a problem, and the gaps between h1 and p seems too much on mobile devices. Other that these, awesome!

    Marked as helpful
    1
  • Shams Wali Sowmo•130
    @Sowmo0509Posted over 2 years ago

    Hey there Afief, nicely done! But there's one little detail you missed, see? The fonts are not relevant with the design. So, you can just easily check the style-guide.md file that comes with the starter content when you download the files to start work with, there check the style-guide and you will find those font names with their font weight. If you have any confusion, feel free to ask around! Thanks!

    Marked as helpful
    0
  • Shams Wali Sowmo•130
    @Sowmo0509Posted over 2 years ago

    Hey Dayo, nicely done on mobile devices! But, on desktop sizing, the div is not centered vertically, also it just shrinks somehow! Maybe you need to take a look, check some min-width or some property for fixing the trouble. Wishes!

    0
  • Shams Wali Sowmo•130
    @Sowmo0509Posted over 2 years ago

    Hello PACO,

    Your site is not mobile responsive. Doesn’t look good on mobile devices. Button is not in the right place on desktop preview, the previous price font is also not correct. Would love to see you updating the issues! Wishes!

    0
  • Shams Wali Sowmo•130
    @Sowmo0509Posted over 2 years ago

    Hey Andrew, I guess you made a mistake on github pages or in github pages directory selection. Please take a look.

    1
  • Selvi•30
    @miofriSubmitted over 2 years ago

    RE the attribution: I don't know how to make it stay in the center with position: fixed and also give it a margin so that it doesn't overlap with the white text box (on mobile view i.e. Surface Duo's, iPad mini, etc.).

    I'm also unsure what is the best practice for font-size scaling. Which unit to use? What are the best sizes?

    The rest was not too difficult although it took me some time to figure out.

    Product preview card component

    1
    Shams Wali Sowmo•130
    @Sowmo0509Posted over 2 years ago

    Hey Selvi, nice work! But–

    1. The footer overflows, try to give it a padding/margin (to the footer or to the bottom of the card),
    2. You missed the cursor: pointer; for button,
    3. And your button is out of the white box on desktop.
    Marked as helpful
    0
  • Shams Wali Sowmo•130
    @Sowmo0509Posted over 2 years ago

    Hi Pooja, There are some beginner level mistakes you've made and I'm here to help. Take a look at your–

    1. "Gabrielle Essence Eau De Parfum" font is not matched. Check the style-guide file from your Starter Files.
    2. Add to Cart button has not cursor: pointer;
    3. The sale price spacing is not correct on mobile layout.
    4. Image is stretched out on mobile devices, try using object-fit: cover;
    1