Ranit Manik• 880
@RanitManik
Submitted
SinanFischer
@SinanFischer
All comments
- SinanFischer• 30
@SinanFischer
Posted
looks good
0 - Martin• 290
@Shanahan914
Submitted
What are you most proud of, and what would you do differently next time?
Went with a mobile-first process this time which I think was a success.
What challenges did you encounter, and how did you overcome them?
Main issue was 1) trying to get the image to fill the appropriate area on the desktop version; and 2) getting the logo positioned correctly on both desktop and mobile. Found relevant materials online and just played about with potential solutions.
What specific areas of your project would you like help with?
Any thoughts on my solutions to the image and logo as I've outlined in the challenges I occurred.
SinanFischer• 30@SinanFischer
Posted
- try to center the icon inside your submit button. It is not centered.
Please don't misunderstand. Of course it is centered. But it's not evenly centered, it's a bit more on top. This is often overlooked in projects. Comes from little spaces inside the svgs oder by text from font styles
1 - Martin• 290
@Shanahan914
Submitted
What are you most proud of, and what would you do differently next time?
Went with a mobile-first process this time which I think was a success.
What challenges did you encounter, and how did you overcome them?
Main issue was 1) trying to get the image to fill the appropriate area on the desktop version; and 2) getting the logo positioned correctly on both desktop and mobile. Found relevant materials online and just played about with potential solutions.
What specific areas of your project would you like help with?
Any thoughts on my solutions to the image and logo as I've outlined in the challenges I occurred.
SinanFischer• 30@SinanFischer
Posted
Hey man, good work!
I took a look at your project and noticed a few little things. Looks solid, but there is still room for improvement. I'll list them for you.
-
when hovering over the submit button, the cursour is an arrow. It should be a pointer. Which makes the clickable icon clear to the user.
-
try to give the <p> a little more line-height. So that it looks more like the design. Otherwise it looks good!
-
your <header> is inside the <articles> and also <mains> The header should be in the body, but not in an article tag or in the main content. He explained it well. It should be done only in specific cases. Feel free to take a look: https://stackoverflow.com/questions/20470345/should-the-header-and-footer-tags-be-inside-the-main-tag
-
try to center the icon inside your submit button. It is not centered.
-
the button still looks a bit too lumpy. Give it a little more width and a larger border radius. As specified in the design.
-
wrap your form (input & submit button) in a <form>
- This improves semantics and accessibility for users with screen readers or other assistive devices.
- In the case of a real project, you can use it to better control data transmission and processing.
- and more...
- I can recommend this article https://www.the-art-of-web.com/html/html5-form-validation/
- did Frontend Mentor create the inline styles in Index.html? This should be avoided when going live. But okay for a practice project.
I hope the feedback helps you! I like your code, keep up the good work!
Translated with DeepL.com (free version) - Greeting from Germany :)
Marked as helpful
0 -
