Skip to content
OverviewSolutions
3
Comments
8
Siddharth Kushwaha
@Sidd5arth

All comments

  • Siddharth Kushwaha•150
    @Sidd5arthPosted over 1 year ago

    Great! solution, but the plan selection is not working properly, it is not updating the UI on changing the plan. To reproduce it - Go the plan selection step and try to select a plan then try to toggle the switch to yearly-> see its not updating the price there.

    0
  • Siddharth Kushwaha•150
    @Sidd5arthPosted over 1 year ago

    great! solution I like that you implemented that languages selection there!

    What I can suggest for now is to improve upon the UI, there is lot of room for improvement there, also try to make component yourself without using third party library, if you really want to learn front-end development otherwise you did great!

    Marked as helpful
    0
  • dannygorgon•10
    @dannygorgonSubmitted over 1 year ago

    Do you think I have approached the problem properly?

    What could I improve?

    Is the README well written?

    QR code component

    1
    Siddharth Kushwaha•150
    @Sidd5arthPosted over 1 year ago

    @dannygorgon Hi there, overall its a good solution!, well if I look into the details you can decrease the width the card and increase the spread and opacity of the vertical shadow on the card.

    Marked as helpful
    0
  • Siddharth Kushwaha•150
    @Sidd5arthPosted over 1 year ago

    A good start I guess, make use of good font I would suggest for now!

    Marked as helpful
    0
  • Siddharth Kushwaha•150
    @Sidd5arthPosted over 1 year ago

    Great! but I think you should watch for padding and margin, the solution is lacking proper proportion, but you did a good job!

    1
  • Siddharth Kushwaha•150
    @Sidd5arthPosted over 1 year ago

    Great solution! but I think you should work on css a bit more! like you should give gap between the image and form input 😊

    0
  • Siddharth Kushwaha•150
    @Sidd5arthPosted over 1 year ago

    nice UI almost similar but you had not implemented you modal logic correctly, you must revert back to register page as you click on dismiss button also you have to show the entered email on the subscribed modal.

    Marked as helpful
    0
  • Siddharth Kushwaha•150
    @Sidd5arthPosted over 1 year ago

    hey nice work! but you had not implemented the validations correctly, you should use regex expression to check if the entered input is actual in email format or not

    0