please help review my accordion project, if there are things that need to be improved please give feedback
Jewels
@ShalomiAhavahAll comments
- @fibradiartaSubmitted 11 months ago@ShalomiAhavahPosted 11 months ago
Hey There!
Nice job on the project!
Here are a couple of things I noticed might need changing:
- Create your custom README.MD
<div class="container">
change this to<main class="contrainer">
for better accessibility- Consider using the <details> element instead of divs Very nice JavaScript code there!
Thats it for now!
Cheers, Julia
Marked as helpful1 - @nandala-allanSubmitted 11 months ago
Some feedback is needed on the HTML & CSS structure and best practices
@ShalomiAhavahPosted 11 months agoHey There!
This looks really professional and neat !
Great Job!
One thing I noticed is that in your README you might want to remove this line:
"To see how you can add code snippets, see below:"
Other than that, Well done!!!
Cheers
J
Marked as helpful1 - @HarshBeheraSubmitted 11 months ago
Feedbacks are most welcome Kindly if calculation part in js has some errors or not
@ShalomiAhavahPosted 11 months agoHey there! Super nice project!
Here's just a couple of easy styling problems I noticed:
- The input boxes should be spaced a little further apart in the desktop view
- The font size in the input boxes for mobile should be smaller
Other than that nice job! Cheers J
1 - @jen67Submitted 12 months ago
Hey everyone! 🌟 Exciting news – I've just wrapped up the FAQ accordion challenge! 🚀 Would love your thoughts, suggestions, or any friendly corrections you might have. Your feedback means the world to me! 🌈🙌 Thanks a bunch! 🎉 #AlwaysLearning #WebDevAdventures #FrontEndMentorsChallenge
- @helenclxSubmitted 12 months agoWhat are you most proud of, and what would you do differently next time?
Being able to create FAQ accordions and solve this challenge without JavaScript.
- @ManiNasihSubmitted about 1 year ago
Hello, every Feedback is welcomed!
- @ZENSE-THAISubmitted about 1 year ago
#Day 15 of frontend training For this piece, it took me 2 days to create. On the first day, I practiced doing it myself using the knowledge I gained from the past 10 days. After encountering a problem that I didn't understand, I went to study on YouTube. and solve problems until getting the finished product
@ShalomiAhavahPosted about 1 year agoWow nice Job! Just keep practicing like that and you'll make it far!
1