hi, just finished this project. i did it but i feel that i am doing something wrong, like there are so simpler solutions, and i complicate things. maybe if someone can take a look at the code and give me some guidance. i would appreciate it
seyide hundeyin
@SeyideHundeyinAll comments
- @Vj3koSubmitted almost 4 years ago@SeyideHundeyinPosted almost 4 years ago
Hi Vjekoslav,
This looks very nice and matches perfectly with the design file.
It's also responsive!!
Have a nice day!
0 - @Sa1nersSubmitted almost 4 years ago
My first time using Grid, so probably some mistakes. I am sure that there is a more efficient way to create 5 stars! I tried using the image repeat function within a separate div but then struggled to get the alignment correct so reverted back to multiple img entries in the html file.
As ever, all feedback, suggestions for improvement welcome.
@SeyideHundeyinPosted almost 4 years agoHi Mark,
I recommend you trying to make it responsive on mobile devices and position the second background image closer to the testimonial cards.
Also, you can try to use flexbox or grid for this challenge as it will make it easier.
Have a nice day!
1 - @Vj3koSubmitted almost 4 years ago
Finished this single price grid layout, i would be really happy if someone can check it out and comment what i can do better, or to shorten code, or anything really. Until next time, keep on coding !
- @Gautam1201Submitted almost 4 years ago
Hi everyone! This was my first challenge. Any feedback or suggestion would be appreciated. Thank you!!
@SeyideHundeyinPosted almost 4 years agoHi Gautam,
Congrats on your first challenge.
I recommend changing the background color to match the design file.
Have a nice day
0 - @shkr1Submitted almost 4 years ago
Hi everyone 👋
I implemented this challenge using a subset or my understanding of BEM and minimal CSS with Grid and Flex when it would make sense. Also I tried to apply semantic HTML.
The spacing and font sizes are a little bit off because I don't use the figma/sketch files 😅.
Any feedback is much appreciated. 🤟
@SeyideHundeyinPosted almost 4 years agoThis looks very nice and responsive on a lot of devices.
I recommend fixing the report issues.
Have a nice day!
0 - @JesusAtao96Submitted almost 4 years ago
Hi all 👋
I decided to do this challenge with SASS, CSS Grid, Flexbox, BEM and a little animations.
Bonus:
- Grid Tracks names for layout.
- Mobile nav only with CSS.
- JS only to hide scroll when mobile navigation is open.
- Background sections using css grid positioning only for testing purpose.
Any feedback is appreciated.
Happy coding 😊.
@SeyideHundeyinPosted almost 4 years agoThis is very nice and it matches the design perfectly.
Happy coding!!
1 - @dinaPutrimpSubmitted almost 4 years ago
Hi, any feedbacks are welcome.
@SeyideHundeyinPosted almost 4 years agoHi Dina,
I would recommend you making this responsive on mobile devices and changing the background color to match the design file.
Have a nice day!
0 - @julespereira96Submitted almost 4 years ago
Any suggestions would be appreciated
@SeyideHundeyinPosted almost 4 years agoHi,
The font size on desktop is so small and it's difficult for me to read.
0 - @shreya-beraSubmitted almost 4 years ago
It will be my pleasure to have feedback for my code!!
@SeyideHundeyinPosted almost 4 years agoHi Shreya,
I would recommend using CSS grid for this challenge and also stick with using h1-h6 without jumping from h1 to h3.
Also on mobile, it doesn't sit in the middle you can use "margin: 0 auto;" to centralize your container.
You can learn more about CSS grid here: https://www.youtube.com/watch?v=jV8B24rSN5o&ab_channel=TraversyMedia
Hope this helps!!
Keep coding and happy coding!!
1 - @leon-bwSubmitted almost 4 years ago
Open to any suggestions for improvement, I do believe there are some things that I can improve with this submission. Thanks
@SeyideHundeyinPosted almost 4 years agoHi Leon,
This looks good and responsive on most devices.
Also, check the accessibility and HTML issues report.
Hope this helps.
Keep coding and happy coding!!
1 - @Firdausi-IqbalSubmitted almost 4 years ago
Feel free to comment :)
If there anyplace where i can improve please let me know through your suggestion. thank you
- @mariaUrdaSubmitted almost 4 years ago
Hi everyone! Here's my very first challenge Feedback will be appreciated :)
@SeyideHundeyinPosted almost 4 years agoHi,
You did a great job on this challenge and you can work on the media queries to make it more responsive on mobile.
2