P
Radu Petre Tarean• 300
@2XG-DEV
Submitted
Sergio Eduardo Castro Ceballos
@SergioCasCeb
All comments
@SergioCasCeb
Posted
The solution seems good to me. :D
- Good structure
- Good custom CSS variables
- Definitively responsive
- Good semantic HTML There could be a little more spacing between the user image and the name as well as between the location and the profile description.
0- Jorge• 40
@Broderpixelv1
Submitted
What are you most proud of, and what would you do differently next time?
I was able to solve the exercise faster, using flexbox seems very useful to me and every time I use it I understand it better, it is still not very clear to me the benefit of the units of measurement em and rem and why they are better than px, how can I see the difference and benefit
What challenges did you encounter, and how did you overcome them?
Importing the fonts gave me problems, but it was solved when I identified the style of each one
What specific areas of your project would you like help with?
In the transition that is made when moving the cursor, I don't know if it is in the correct place, or declared, because sometimes when the page loads all the objects move
@SergioCasCeb
Posted
Overall really good job, and I like the extra animation you added to the card on hover, but there are a few things you could use to improve it.
- Your spacing is a bit of from the design guidelines given in the Figma files.
- You should not use the main element for you component, as that is not a good practice and should be used as the overarching parent of you content.
- Since your hover is on the card, you didn't specify any behavior on focus and you font have any interactive element in your card title like and <a> element the focus behavior of course doesn't work.
- Also you might be overdoing it with the HTML tags.
1 @mohamed-fathy3010
Submitted
What are you most proud of, and what would you do differently next time?
This is the first time I use BEM. next time i will try to use other tools like SCSS or TS to train my self more with them.
What challenges did you encounter, and how did you overcome them?
No challenges encountered but i toke some time searching for some best practices and standards.
What specific areas of your project would you like help with?
Any feedback is appreciated.
@SergioCasCeb
Posted
First of all, really well done with the use of the BEM methodology.
Only a few things that could help you improve it further:
- You forgot to make the component fit all screen sizes. Even though the designs are made in the screen sizes of 375px and 1440px, you should always remember that screen sizes can go as small as 320px.
- Add some padding to you main container so that the content are not touching the edges of the screen in small screen sizes
0
