All comments

• 

  Spencer Brian Baiden•10

  @spencerbbrianSubmitted over 2 years ago

  First HTML & CSS project. Any suggestions to better make the code better?

  

  QR CODE COMPONENT

  2

  40
  

  Sebastian Black•60

  @SebbyBlackPosted over 2 years ago

  There are a few suggestions I can see, though some specifically relate to this project and not in general.

  • Since there is only one h1, there's not really a need to give it a class, instead just style the h1 itself. (Specific to this project)

  • You could change your "container" div into a section tag, not only will this make it a bit more readable as to what is going on, but it's also more readable for web browsers as well. (General use depending on content of page)

  • The "worded-card" div seems redundant. You could have the "main" tag be your container, and the "container div" (or section) be the worded-card portion. (General use)

  1

  This comment has received 1 replyShow
• 

  Vi-Linh Nguyen•40

  @ViLinh27Submitted over 2 years ago

  I'm still not that good at centering things vertically. This was a good review of CSS basics though. I'll probably do these challenges as a summer project or something.

  

  Order Summary Component my attempt

  1

  30
  

  Sebastian Black•60

  @SebbyBlackPosted over 2 years ago

  Design :

  • Overall solid, there is a drop shadow on the button though, straight forward to add.

  Code :

  • There's a spelling error in your main div. you forgot an "s" in class.
  • In your buttons, there is no need to wrap the text in other tags (In your case the h4 tag), rather I'm assuming you where trying to change the font size, instead just use CSS to do so.
  • If you haven't, look more into HTML semantic tags to make the code a little more readable as far as what is going on.

  Overall : You did a great job, mostly minor things that just take your code that extra step.

  Marked as helpful

  0
• 

  Eduardo DdC•20

  @ryu-edSubmitted over 2 years ago

  I would like your feedbacks. Since the angular, react or vue frameworks are not yet used. Thanks.

  

  Simple and without frameworks

  1

  60
  

  Sebastian Black•60

  @SebbyBlackPosted over 2 years ago

  If you haven't already, read the accessibility issues report, overall your work looks good, a few minor styling issues, font colors and size, and box shadow intensity. Good job none the less!

  Also try editing the readme they give you to show what you learned/did in the process of working on the card. Not necessary but could be beneficial down the line.

  Marked as helpful

  0