@m-waris
Submitted
Sbnrox
@Sbnrox
All comments
- Sbnrox• 30
@Sbnrox
Posted
Great job! The only things I would suggest is to change the container div to a main and to give a more detailed alt code for the image such as "QR code leading to frontendmentor.io" but other than that you did great.
1 - Sbnrox• 30
@Sbnrox
Submitted
This is the second project I'm trying and it way harder then expected. Thank you so much for any and all feedback you offer.
- In the guide, it said that tr and size had to be in span in order to be able to add the above styling (.c-product-card__btn {display: flex;align-items: center;gap: 1ch;}). However, I had to remove that styling in order for it to be centered by itself. Can anyone explain to me what happened there?
- Why doesn't putting a border radius on the container work? Why is there still no border-radius after I added it to the image?
- When I try to center the desktop, the whole mobile gets ruined. How do I stop that?
- I had to manually input a height in the picture tag in order for it to work. What was I supposed to do instead?
- I had to put a negative margin because there was a gap between the pictures and the text. Is there another way to prevent it?
- How do I break up the text to make the exact placement of the words like in the design?
- Is there any unnecessary code, or is there a better way of doing this than what I did? And of course, any other feedback would be greatly appreciated.
Sbnrox• 30@Sbnrox
Posted
Does anyone have feedback?
0 - Sbnrox• 30
@Sbnrox
Submitted
Basic QR Code project using a main div tag. I'm looking for feedback on ways I can improve the code. Specifically, if there are unnecessary lines of code. All comments are appreciated.
Sbnrox• 30@Sbnrox
Posted
Thank you everyone. I tried using Flexbox earlier but I must have done something wrong as it didn't work. I made the changes and it helped. Thank you
1
