Sarang-Patel
@Sarang-PatelAll comments
- @Luxeli0004Submitted almost 3 years ago@Sarang-PatelPosted almost 3 years ago
Congracts on your solution.
To git rid of the accessibility issues:
1.) contain all ur contents of body tag inside main tag. 2.) use atleast one h1 tag.
hope this helps.
Marked as helpful0 - @Taro2211Submitted almost 3 years ago
Hello everyone. Any feedback or tip would be great help. Thank you in advance !!!
@Sarang-PatelPosted almost 3 years agoCongratulations on your solution.
Just a tip.
The "Equilibrium #3429" part has hover effect even outside the content. To fix that set its width to fit-content in css.
Hope it helps.
Marked as helpful1 - @borakbSubmitted almost 3 years ago
I would like feedback on how I can improve my solution.
@Sarang-PatelPosted almost 3 years agoCongratulations on your solution.
Just a few things to note:
- The "Equilibrium #3429" has hover effect even outside the content. To fix that set its width to fit content in css.
- Use alt attribute for images.
- Contain all the code in body tag in main tag.
- Use One h1 tag.
points 2,3,4 will help in removing accessibility issues.
Hope this helps.
Marked as helpful1 - @NiharSaxenaSubmitted almost 3 years ago@Sarang-PatelPosted almost 3 years ago
Congratulations, on getting the solution.
Just a few things to note:
- add all elements in the body in a main tag
- use atleast one h1 tag.
- use :hover in css to get the hover effects of changing color.
points 1 & 2 will help remove accessibility issues.
Hope this helps.
0 - @wminaungSubmitted almost 3 years ago@Sarang-PatelPosted almost 3 years ago
Awesome work. You got the design very nice.
Just a few things.
- Font for main text is not same
- center the text using text-align
- add all elements in the body in a main tag
- use atleast one h1 tag points 3 and 4 will help remove accessibility issues.
Hope this helps.
Marked as helpful1 - @nejidevelopsSubmitted almost 3 years agoWhat are you most proud of, and what would you do differently next time?
I'll go for a Javascript Framework to with it rather than basic HTML and CSS
What challenges did you encounter, and how did you overcome them?N/A
What specific areas of your project would you like help with?Currently on this challenge not applicable
@Sarang-PatelPosted almost 3 years agoCongratulations on getting the design so accurate.
Just one thing, use font weights given in the style guide. And contain your code in main tag, and have one h1 tag to get rid of the ACCESSIBILITY ISSUES.
Marked as helpful0