All comments

• 

  ElmoCoso385•30

  @ElmoCoso385Submitted over 2 years ago

  

  QrCode component using flexbox

  1

  40
  

  Sarah Watkeys•30

  @SarahWatkeysPosted over 2 years ago

  You got the sizing much better than I did!

  One issue we both had is in the accessibility report. Basically we need to add landmarks in the HTML in order to make it more accessible, for example users with screenreaders. So, instead of div tags, we can use a main tags (and other relevant landmark tags depending on the project). Can also use a footer tag for the attribution.

  0

  This comment has received 1 replyShow
• 

  Kirin•40

  @jhsanchezmSubmitted over 2 years ago

  What I found difficult is the deployment and the documentation process I think I've done a lot of commit spam just modifying the README.md file.

  

  QR Code Component. Used HTML, CSS and Flexbox

  4

  20
  

  Sarah Watkeys•30

  @SarahWatkeysPosted over 2 years ago

  Hi Kirin One suggestion that I was given that helped improve the accessibility report was to use things like <main> and <footer> tags, instead of <div> tags. My original had the same accessibility issues as you, but this took care of it.

  Marked as helpful

  1

  This comment has received 1 replyShow