Skip to content
OverviewSolutions
24
Comments
13
Saif Narpali
@SaifN97

All comments

  • Saif Narpali•590
    @SaifN97Posted about 3 years ago

    Great work on this one!👏👏

    I'll suggest try using em units for margin / padding.

    When you use em units the spacing adjusts automatically depending on the font-size of the element as we shrink things down for mobile view.

    Have fun coding :)

    1
  • Indarta•10
    @indartawSubmitted over 3 years ago

    Hi, I'm a newbie developer. This is my first time using flexbox and grid. So I have no idea whether it is a good practice. Can somebody explain to me about the good practices for this solution? For example, what to use for the buttons, what to use for the change plan section, etc. I left out the button active state due to brain exhaustion lol.

    Just Html and CSS try using flexbox and css grid for the first time

    1
    Saif Narpali•590
    @SaifN97Posted over 3 years ago

    Hey Indarta, Good work on this one, Looks impressive as a first project!

    I see you're using div to wrap everything which is not ideal..

    I'll suggest look more into using correct HTML elements

    Have fun coding! :)

    0
  • Saif Narpali•590
    @SaifN97Posted over 3 years ago

    Hey Humaira, great work on this one!

    I see you're mixing up css units and I remember struggling on that too.

    I want to share a general rule of thumb that made it easier for me 👇..

    • % for width and height
    • rem for setting font-size
    • em for margin and padding

    Have fun coding :)

    Marked as helpful
    0
  • Carlos•1,110
    @Carlos-A-PSubmitted over 3 years ago

    I wasn't able to use Font Awesome icons since they always appeared as blank squares so I resulted too downloading png icons. However, I found it difficult to change the colors when I hover over the social icons. The default colors for two of them were black and I tried to use the filter property but was only able to turn them white.

    HTML standard markup, JavaScript, CSS, media queries

    1
    Saif Narpali•590
    @SaifN97Posted over 3 years ago

    Hey Carlos great job on this one!

    I struggled on changing svgs color on hover too.. This pen helped me👇 Css filter

    Marked as helpful
    1
  • Saif Narpali•590
    @SaifN97Posted over 3 years ago

    Hey Mohamed Mahir great job on this one!

    The card content is flowing out while going small. I'll suggest avoid setting a fixed height to your cards and use padding whenever you need more background space.

    Have fun coding :)

    Marked as helpful
    0
  • Saif Narpali•590
    @SaifN97Posted over 3 years ago

    Good job on the challenge 👏👏

    I am a big fan of sass too. They recently made a public notice on the deprecation of the @import rule, they are encouraging developers to use @use instead of @import.

    PS: with the @use rule, your CSS partials will be namespaced.

    Also I'll suggest looking more into the combo of using rem , em and % units instead of using px as it helps alot with the responsiveness.

    Lastly try to avoid setting fixed heights and use paddings and margins instead.

    Have fun coding! :)

    Marked as helpful
    0
  • Saya Takahashi•10
    @saya-takahashiSubmitted over 3 years ago

    Hey guys! This is my first challenge, so I struggled a lot to complete the project. I have no particular questions, but any feedback is appreciated. Thank you:)

    Stats preview card component

    2
    Saif Narpali•590
    @SaifN97Posted over 3 years ago

    Hey Saya! Great work on this one!🎉

    I'll suggest look more into using the combo of rem and em units.. I struggled on this one too but learning to use the correct units helped me big time on my next projects!!

    Have fun coding :) Cheers!

    Marked as helpful
    0
  • Saif Narpali•590
    @SaifN97Posted over 3 years ago

    Hey devbev! Good work on this one!

    I'll suggest look more into using the correct units instead of using px for everything.. I struggled on this too but learning about rem, em and percentages helped me big time!

    Have fun coding! Cheers!

    0
  • stephmunez•435
    @stephmunezSubmitted over 3 years ago

    Hello, I have one question, it has added a nice effect accidentally not gonna lie, but how do you keep the buttons' size from growing when clicked. Any suggestions on how I can improve are welcome!

    3-column preview card component

    1
    Saif Narpali•590
    @SaifN97Posted over 3 years ago

    Hey sjtmunez! Good work on this one!

    I think the border is causing the problem of resizing the button element while clicking as there is no border on it initially.. Also I'll suggest avoid setting fixed heights and use margins and paddings instead..

    Hope this was helpful to you..

    Have fun coding! Cheers!

    Marked as helpful
    0
  • Swan-Yee-Tun•225
    @developedBySwanSubmitted over 3 years ago

    Hello, This is my Project use with HTML and SCSS. I got a lot of exp and knowledge about CSS.

    Warmly welcome your feedback and suggestion.

    I have a question relate this project.

    • I spend around 3 hours to complete this site. I wanna know it is normal or not.

    Thank You, Everyone. Keep coding.

    HTML, CSS site using HTML, CSS Grid & flex

    1
    Saif Narpali•590
    @SaifN97Posted over 3 years ago

    Good job on the challenge 👏👏

    I am a big fan of sass too. They recently made a public notice on the deprecation of the @import rule, they are encouraging developers to use @use instead. import

    PS: with the @use rule, your CSS partials will be namespaced.

    0
  • Saif Narpali•590
    @SaifN97Posted over 3 years ago

    Hey good job on this one! I'll suggest avoid using fix heights unless you really need one and also look more into how you can use "em" units the combo of "rem" together instead of just rem units.. Hope this was helpful :) Have fun coding.

    Marked as helpful
    1
  • Saif Narpali•590
    @SaifN97Posted over 3 years ago

    Hey! good job on this one.!! I'll suggest trying mobile first approach because its saves so much time and lines of code trying to overwrite the desktop layout complexity.. Also take a look at using "em" units for margins and paddings instead of setting fix "%"s..

    Hope this was helpful :)

    Marked as helpful
    0