Would love some feedback!
Sergio Linero
@SLineroDevAll comments
- @peterramirez18Submitted about 3 years ago@SLineroDevPosted about 3 years ago
Instead of using an <img> tag with position: absolute as background. It would be better to just add a "background-image: url() + background-repeat: repeat-x" to the body.
Marked as helpful1 - @blladeraniSubmitted about 3 years ago
I am new to web developing. I tried my best to complete this challange. I whould love to hear your suggestions :)
@SLineroDevPosted about 3 years agoYou missed the background and the hover effects.
0 - @Kareemah-codesSubmitted about 3 years ago
Hello everyone!, This is my first project on Frontend mentor, any tips will be highly appreciated. I am also not sure if it is fully responsive across all devices. If I can get some help with that, it would be really appreciated . Thank you!
@SLineroDevPosted about 3 years agoI have a few recommendations: body { height: 100vh; /* width: 100%; */ <-removing this margin: 0; <-adding this font-family: 'Red Hat Display', sans-serif; background-color: hsl(225, 100%, 94%); }
.order_summary_card_flex-container { display: flex; justify-content: center; align-items: center; width: 100%; height: 100%; <-adding this }
And you have your card centered and no scrollbar. I think its very important that margin: 0 for the body. All browsers add it by default and it´s a pain in the ass, specially for scrollbars.
Marked as helpful1