Skip to content
OverviewSolutions
10
Comments
3
Sj
@SJ-74

All comments

  • Sj•120
    @SJ-74Posted 4 months ago

    Well done on your challenge. Regarding your CSS. I'd like to point out a couple of things.

    1. Using max-height should be avoided as much as you can.
    2. px can be used to replace shadow length and padding can be set using ems.
    1
  • Sj•120
    @SJ-74Posted 6 months ago

    Great job on completing the challenge. Few things I want to point out:

    • The background color of body is different compared to the design. (Color codes are provided in style-guide.md file).
    • Giving some shadow to the card.
    • Padding inside the card is more compared to the design.
    • Instead of the generic div tag, try using semantic html tags.
    • Avoid giving a fixed height and width. You should use max-width and calc for such operations.
    • Should use relative units instead of px for size.
    0
  • Sj•120
    @SJ-74Posted about 3 years ago

    Greetings,

    I'd suggest a few updates/changes.

    • Your .project is wrapping all the content inside. So, instead of giving it a 'width:1440px` you should have left it because on screen-size larger than 1440 the background-color kinda changes at the ends (changes to white).
    • For some reason the heading text (your h1) is not visible on my screen.
    • Also, I'd suggest going mobile first flow(though it's totally up to you) because you don't have to write as much media query. It reduces most of your work. So, instead of changing everything, you just have to change a few things.
    Marked as helpful
    0