Any feedback is more than welcome
Ricardo
@RyXkciAll comments
- @AleksandarV91Submitted about 3 years ago@RyXkciPosted about 3 years ago
Excellent! It's pretty much perfect. Literally the only thing I would do is center the whole section. I normally set a main as 100% width and 100vh, put the whole thing in there, flex it and use "justify center and align center" and keep the "coded by" out of it. From now on I'm going to to set the main as "calc(100vh-20%) or something to keep the text at the bottom.
1 - @zitescodySubmitted about 3 years ago
I had trouble with this one. Primarily keeping the text within the boundaries of their respective boxes.
Please let me know how I can do better!
@RyXkciPosted about 3 years agoThe layout is great! Regarding the text, do you mean having it break where it does in the image? If so, maybe a little more padding should do it.
Marked as helpful0 - @ntabucejoSubmitted about 3 years ago@RyXkciPosted about 3 years ago
Great job with the layout! Nice work! The only thing a bif off is the text breaking, but I think that could be sorted by just making all the cards smaller. Regardng the html issues I think you can sort that by just changing the markup structure. I kept all the name as h2s, the big quotes as blockquotes and the rest as paragraphs.
Marked as helpful1 - @AlanBoulesteixSubmitted about 3 years ago
Hello everyone, it's my first time submitting my solution, so if you have any feedback I'll be glad to hear it.
I couldn't find a good solution to put a purple filter on the picture without using <img> so if you know how to do so let me know.
@RyXkciPosted about 3 years agoWhat I did was use the image as the background of a section, and inside that section I made a div with a class of overlay. In css I called that class, set the width and height 100%, set the purple colour and then opacity to make it more transparent. I didn't get the perfect colour though.
Marked as helpful1