Frontend Mentor | Rupsnigdha Kashyap's profile

@Haswolinsk

Submitted over 1 year ago

Someone any idea of how for simplify my code? I have no idea how I could further simplify this code, but I welcome suggestions :]

@Rupsnigdha

Posted over 1 year ago

Okay so here are some suggestions :

for <p style="margin-top: 0;">P E R F U M E</p>, t=you could've also used letter-spacing: x px; to get more control.
From the next time, I would not use inline styling unless absolutely necessary. So for example, even though you have a h1 {...} in your <styles> tag, you still have added inline styles to the <h1> in the HTML. I would definitely recommend maintaining a different file for CSS and maybe even go and look into CSS selectors in depth. It really helps selecting and fine-tuning specific elements.
Instead of using margins on each element of .card, try using display: flex; align-items: space-between
Try storing the color palette and fonts as variables in the :root element. So for example something like :

:root {
     --color-primary: #0FF;
     --color-secondary: #000;
     --color-white: #FFF;
     --font: "Montserrat", sans-serif;
}

Other than this, you did a really good job making this. Congratulations it looks amazing!

Marked as helpful

All comments