All comments

• 

  Sofia•10

  @ArchSofiaSubmitted over 2 years ago

  What would be the best practices for this project?

  

  Product preview card component

  1

  30
  

  Rosalia•90

  @RosaliaLeyPosted over 2 years ago

  Awesome work Sofia! I would recommend adding alternative text to your image for accessibility purposes. <img src=/images/icon-cart.svg> is missing alt . Also, the articles lack headings. You could use a validator (https://validator.w3.org), and an accessibility plug-in like wave to double check. I will submit a pull request on your GitHub, take a look and commit the changes if you'd like :)

  0

  This comment has received 1 replyShow
• 

  Karolfm12•190

  @Karolfm12Submitted over 2 years ago

  

  html css flexbox

  1

  40
  

  Rosalia•90

  @RosaliaLeyPosted over 2 years ago

  Hi, great work! I submitted a pull request on your GitHub. I fixed the img tag and added alt for semantic meaning(always provide an alt attribute for images). Fixed h4 heading to a p tag, font size should be adjusted in CSS for styling purposes. Adjusted page content landmarks by adding main, section, and footer.

  0
• 

  Cristian Vega•90

  @crisvegadevSubmitted over 2 years ago

  

  Product preview card component

  1

  30
  

  Rosalia•90

  @RosaliaLeyPosted over 2 years ago

  Hi, great work overall. I submitted a pull request to your GitHub for semantic meaning on your code. "I modified index.html to have a significant page area called <section>. It helps screenreaders. And, the page first-level heading to have semantic meaning. If the desired font size is a <h2> size, all styling should be happening in CSS."

  0